tests: XFAIL in the face of a MacOS X bug

* doc/autoconf.texi (Limitations of Usual Tools) <sed>: Mention
the issue.
* tests/torture.at (Substitute and define special characters):
Detect if sed cannot process 8-bit bytes in the C locale.
* THANKS: Update.
Reported by Rochan.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/ChangeLog b/ChangeLog
index 1b47a2c429e3cf83f3eb8de822ff3904785cb1b9..311f41f275c5c32f00aa978cb70027e473341f9e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2010-09-21  Eric Blake  <eblake@redhat.com>
+
+       tests: XFAIL in the face of a MacOS X bug
+       * doc/autoconf.texi (Limitations of Usual Tools) <sed>: Mention
+       the issue.
+       * tests/torture.at (Substitute and define special characters):
+       Detect if sed cannot process 8-bit bytes in the C locale.
+       * THANKS: Update.
+       Reported by Rochan.
+
 2010-09-20  Eric Blake  <eblake@redhat.com>
 
        autom4te: don't filter out portions of location traces

diff --git a/THANKS b/THANKS
index cb1589b2f22e33d1958ddc9c14faf66af0700648..4acb36f63df34b13c388a8685290a431224f44dd 100644 (file)
--- a/THANKS
+++ b/THANKS
@@ -339,6 +339,7 @@ Richard Stallman            rms@gnu.org
 Robert Lipe                 robertlipe@usa.net
 Robert S. Maier             rsm@math.arizona.edu
 Roberto Bagnara             bagnara@cs.unipr.it
+Rochan                      rochan@ices.utexas.edu
 Roger Leigh                 rleigh@whinlatter.ukfsn.org
 Roland McGrath              roland@gnu.org
 Rolf Ebert                  rolf.ebert.gcc@gmx.de

diff --git a/doc/autoconf.texi b/doc/autoconf.texi
index 642430299837aace6349c29d14fb8523b5c3fe3e..66d8a211b1f7701ab17242d5169665cc8c485c4d 100644 (file)
--- a/doc/autoconf.texi
+++ b/doc/autoconf.texi
@@ -18700,6 +18700,28 @@ implementations have an input buffer limited to 4000 bytes.  Likewise,
 not all @command{sed} implementations can handle embedded @code{NUL} or
 a missing trailing newline.
 
+Remember that ranges within a bracket expression of a regular expression
+are only well-defined in the @samp{C} (or @samp{POSIX}) locale.
+Meanwhile, support for character classes like @samp{[[:upper:]]} is not
+yet universal, so if you cannot guarantee the setting of @env{LC_ALL},
+it is better to spell out a range @samp{[ABCDEFGHIJKLMNOPQRSTUVWXYZ]}
+than to rely on @samp{[A-Z]}.
+
+Additionally, Posix states that regular expressions are only
+well-defined on characters.  Unfortunately, there exist platforms such
+as MacOS X 10.5 where not all 8-bit byte values are valid characters,
+even though that platform has a single-byte @samp{C} locale.  And Posix
+allows the existence of a multi-byte @samp{C} locale, although that does
+not yet appear to be a common implementation.  At any rate, it means
+that not all bytes will be matched by the regular expression @samp{.}:
+
+@example
+$ @kbd{printf '\200\n' | LC_ALL=C sed -n /./p | wc -l}
+0
+$ @kbd{printf '\200\n' | LC_ALL=en_US.ISO8859-1 sed -n /./p | wc -l}
+1
+@end example
+
 Portable @command{sed} regular expressions should use @samp{\} only to escape
 characters in the string @samp{$()*.0123456789[\^n@{@}}.  For example,
 alternation, @samp{\|}, is common but Posix does not require its

diff --git a/tests/torture.at b/tests/torture.at
index 673c7a596a238be56e6c81e71647c3b603927c71..511834df688ff6a93ad7d79fb2366bda65c0cab2 100644 (file)
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -882,6 +882,9 @@ AT_CLEANUP
 AT_SETUP([Substitute and define special characters])
 AT_KEYWORDS([AC@&t@_DEFINE AC@&t@_DEFINE_UNQUOTED])
 
+AT_XFAIL_IF([byte=\\200s; dnl
+test `{ printf $byte; echo; } | sed -n '/^./p' | wc -l` = 0])
+
 AT_DATA([Foo.in], [@foo@
 @bar@@notsubsted@@baz@ stray @ and more@@@baz@
 abc@bar@baz@baz