AP MLD: Clean up disassoc handling for non-AP MLD link validity check

The check for the non-AP MLD link being valid can be done one level
outside the loop that tries to find a matching AP link.

Signed-off-by: Jouni Malinen <quic_jouni@quicinc.com>

diff --git a/src/ap/sta_info.c b/src/ap/sta_info.c
index 042a5a28622c57ba4f60010493359f1024921caf..9de5b0a1c65abeb0400f24a9deffa568defff957 100644 (file)
--- a/src/ap/sta_info.c
+++ b/src/ap/sta_info.c
@@ -970,12 +970,12 @@ static bool ap_sta_ml_disconnect(struct hostapd_data *hapd,
        interfaces = assoc_hapd->iface->interfaces;
 
        for (link_id = 0; link_id < MAX_NUM_MLD_LINKS; link_id++) {
+               if (!assoc_sta->mld_info.links[link_id].valid)
+                       continue;
+
                for (i = 0; i < interfaces->count; i++) {
                        struct sta_info *tmp_sta;
 
-                       if (!assoc_sta->mld_info.links[link_id].valid)
-                               continue;
-
                        tmp_hapd = interfaces->iface[i]->bss[0];
 
                        if (!tmp_hapd->conf->mld_ap ||