]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: core: Constify struct configfs_item_operations and configfs_group_operations
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 29 Dec 2025 11:27:43 +0000 (12:27 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 31 Dec 2025 17:59:26 +0000 (17:59 +0000)
'struct configfs_item_operations' and 'configfs_group_operations' are not
modified in this driver.

Constifying these structures moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
   5037    1528      64    6629    19e5 drivers/iio/industrialio-sw-device.o
   5509    1528      64    7101    1bbd drivers/iio/industrialio-sw-trigger.o

After:
=====
   text    data     bss     dec     hex filename
   5133    1432      64    6629    19e5 drivers/iio/industrialio-sw-device.o
   5605    1432      64    7101    1bbd drivers/iio/industrialio-sw-trigger.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/industrialio-sw-device.c
drivers/iio/industrialio-sw-trigger.c

index cdaf30a3f233479ed4ffb31d389c61ddd0f2c7a4..3582524de0b8d33cf13730d79b861118d94570b0 100644 (file)
@@ -148,7 +148,7 @@ static void device_drop_group(struct config_group *group,
        config_item_put(item);
 }
 
-static struct configfs_group_operations device_ops = {
+static const struct configfs_group_operations device_ops = {
        .make_group     = &device_make_group,
        .drop_item      = &device_drop_group,
 };
index d86a3305d9e8d7bdfcedf2488fbf328427507ca2..334b6b10a7848351d1f298f8b07c55f259116a60 100644 (file)
@@ -152,7 +152,7 @@ static void trigger_drop_group(struct config_group *group,
        config_item_put(item);
 }
 
-static struct configfs_group_operations trigger_ops = {
+static const struct configfs_group_operations trigger_ops = {
        .make_group     = &trigger_make_group,
        .drop_item      = &trigger_drop_group,
 };