wrapper: remove false checks for snprintf

LGTM, reported that the negative value checks for snprintf() will
always be false.  The reason being the snprintf() are used to print
into a character buffer, hence chances of stream error or wide
characters encoding error are not valid here. Remove the negative
return value check across the file done after snprintf().

Reported-by: LGTM
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/wrapper.c b/src/wrapper.c
index 3d50c5a7c2e6cda8b4c8dec5b19605f263a20cc5..826ccad58e2ddfd074a4354ae364b19530205127 100644 (file)
--- a/src/wrapper.c
+++ b/src/wrapper.c
@@ -532,7 +532,7 @@ int cgroup_set_value_int64(struct cgroup_controller *controller,
                        ret = snprintf(val->value,
                                sizeof(val->value), "%" PRId64, value);
 
-                       if (ret >= sizeof(val->value) || ret < 0)
+                       if (ret >= sizeof(val->value))
                                return ECGINVAL;
 
                        val->dirty = true;
@@ -581,7 +581,7 @@ int cgroup_set_value_uint64(struct cgroup_controller *controller,
                        ret = snprintf(val->value,
                                sizeof(val->value), "%" PRIu64, value);
 
-                       if (ret >= sizeof(val->value) || ret < 0)
+                       if (ret >= sizeof(val->value))
                                return ECGINVAL;
 
                        val->dirty = true;
@@ -641,7 +641,7 @@ int cgroup_set_value_bool(struct cgroup_controller *controller,
                                                sizeof(val->value), "0");
                        }
 
-                       if (ret >= sizeof(val->value) || ret < 0)
+                       if (ret >= sizeof(val->value))
                                return ECGINVAL;
 
                        val->dirty = true;