]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
node_device: udev: Fix memory leak
authorCole Robinson <crobinso@redhat.com>
Tue, 12 Jan 2010 20:01:21 +0000 (15:01 -0500)
committerCole Robinson <crobinso@redhat.com>
Wed, 13 Jan 2010 12:02:19 +0000 (07:02 -0500)
We are setting the same property two different ways without
free'ing in between. Just drop the second assignment.

src/node_device/node_device_udev.c

index a9e196d064e29e6ae90b7d47bafd70383c3f6a89..ff6bd46c68ae4ba51b596b854f8527a8e1b57d2b 100644 (file)
@@ -997,11 +997,7 @@ static int udevProcessStorage(struct udev_device *device,
         goto out;
     }
     data->storage.block = strdup(devnode);
-    if (udevGetStringProperty(device,
-                              "DEVNAME",
-                              &data->storage.block) == PROPERTY_ERROR) {
-        goto out;
-    }
+
     if (udevGetStringProperty(device,
                               "ID_BUS",
                               &data->storage.bus) == PROPERTY_ERROR) {