]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
m4: enable -fstack-protector-strong on mingw
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 22 Jul 2020 16:29:19 +0000 (17:29 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Thu, 23 Jul 2020 13:58:06 +0000 (14:58 +0100)
Historically we avoided -fstack-protector* since it resulted in a broken
build on Mingw. In GCC 10 in Fedora though, we have the opposite problem,
getting a broken build if we don't enable one of the -fstack-protector*
options. This also works in GCC 9, so we don't need to worry about the
old brokeness which evidentally got fixed at some time without noticing.

Reviewed-by: Laine Stump <laine@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
m4/virt-compile-warnings.m4

index d3538d59f82fe16001967f6cd1af4a95a4a95d3c..d171d09991bf70e3e3a234d02dae4867f4c47cd9 100644 (file)
@@ -169,13 +169,11 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
     gl_WARN_ADD([-Wframe-larger-than=262144], [RELAXED_FRAME_LIMIT_CFLAGS])
 
     # Extra special flags
-    dnl -fstack-protector stuff passes gl_WARN_ADD with gcc
-    dnl on Mingw32, but fails when actually used
     case $host in
        aarch64-*-*)
        dnl "error: -fstack-protector not supported for this target [-Werror]"
        ;;
-       *-*-linux*)
+       *-*-linux* | *-*-mingw*)
        dnl Prefer -fstack-protector-strong if it's available.
        dnl There doesn't seem to be great overhead in adding
        dnl -fstack-protector-all instead of -fstack-protector.