xm_internal.c: fix locking bug: s/Lock/Unlock/

* src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
try to acquire it) upon failure, just before returning.

diff --git a/ChangeLog b/ChangeLog
index f1ab9f9079ec2599b920f1f76ede52fa92416971..febf84989af2fcf21e5cdb35c3a430a0bda51463 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+Thu Jan 22 20:17:35 +0100 2009 Jim Meyering <meyering@redhat.com>
+
+       xm_internal.c: fix locking bug: s/Lock/Unlock/
+       * src/xm_internal.c (xenXMDomainDefineXML): Release lock, (don't
+       try to acquire it) upon failure, just before returning.
+
 Thu Jan 22 10:35:03 PST 2009 John Levon <john.levon@sun.com>
 
        * gnulib/tests/.cvsignore: add test-random_r 

diff --git a/src/xm_internal.c b/src/xm_internal.c
index 31f56b73e16c2188e17be3e0326cf56fe7dd518d..b420e8083fe58046905cb67e3f821559969e7ecf 100644 (file)
--- a/src/xm_internal.c
+++ b/src/xm_internal.c
@@ -2357,7 +2357,7 @@ virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) {
 
     if (!(def = virDomainDefParseString(conn, priv->caps, xml,
                                         VIR_DOMAIN_XML_INACTIVE))) {
-        xenUnifiedLock(priv);
+        xenUnifiedUnlock(priv);
         return (NULL);
     }