]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: fix QED disk test in xlconfigtest
authorJim Fehlig <jfehlig@suse.com>
Mon, 16 Jan 2017 18:31:42 +0000 (11:31 -0700)
committerJim Fehlig <jfehlig@suse.com>
Tue, 17 Jan 2017 15:41:59 +0000 (08:41 -0700)
When LIBXL_HAVE_QED is defined, xlconfigtest fails

 9) Xen XL-2-XML Format disk-qed  ... command line: config parsing error
 in disk specification: no vdev specified in
 `target=/var/lib/libvirt/images/XenGuest2,format=qed,backendtype=qdisk,vdev=hda,access=rw'
FAILED

As per the xl-disk-configuration(5) man page, target= must come
last in the disk specification when specified by name:

When this parameter is specified by name, ie with the target=
syntax in the configuration file, it consumes the whole rest of the
DISKSPEC including trailing whitespaces.  Therefore in that case
it must come last.

Change tests/xlconfigdata/test-disk-qed.cfg to adhere to this
restriction.

tests/xlconfigdata/test-disk-qed.cfg

index ee904e010c679eaea02e696b4eefde9ec1477b9f..78421767debba2bd3f04a2332afb37b8d07a83b9 100644 (file)
@@ -22,4 +22,4 @@ parallel = "none"
 serial = "none"
 builder = "hvm"
 boot = "d"
-disk = [ "target=/var/lib/libvirt/images/XenGuest2,format=qed,backendtype=qdisk,vdev=hda,access=rw" ]
+disk = [ "format=qed,backendtype=qdisk,vdev=hda,access=rw,target=/var/lib/libvirt/images/XenGuest2" ]