]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: acme: display the complete challenge_ready command in the logs
authorWilliam Lallemand <wlallemand@haproxy.com>
Thu, 23 Oct 2025 09:01:13 +0000 (11:01 +0200)
committerWilliam Lallemand <wlallemand@haproxy.com>
Thu, 23 Oct 2025 09:14:07 +0000 (11:14 +0200)
When using a wildcard DNS domain in the ACME configuration, for example
*.example.com, one might think that it needs to use the challenge_ready
command with this domain. But that's not the case, the challenge_ready
command takes the domain asked by the ACME server, which is stripped of
the wildcard.

In order to be clearer, the log message shows exactly the command the
user should sent, which is clearer.

src/acme.c

index 6e97608293827a8f74144192ca03777f45c0b36d..ffc8ad7ec20964b00684c410dce6a1ed7fd89ebb 100644 (file)
@@ -1699,8 +1699,8 @@ int acme_res_auth(struct task *task, struct acme_ctx *ctx, struct acme_auth *aut
                                goto error;
                        }
 
-                       send_log(NULL, LOG_NOTICE,"acme: %s: dns-01 requires to set the \"_acme-challenge.%.*s\" TXT record to \"%.*s\" and use the \"acme challenge_ready\" command over the CLI\n",
-                                                                    ctx->store->path, (int)auth->dns.len, auth->dns.ptr, (int)trash.data, trash.area);
+                       send_log(NULL, LOG_NOTICE,"acme: %s: dns-01 requires to set the \"_acme-challenge.%.*s\" TXT record to \"%.*s\" and use the \"acme challenge_ready %s domain %.*s\" command over the CLI\n",
+                                                                    ctx->store->path, (int)auth->dns.len, auth->dns.ptr, (int)trash.data, trash.area, ctx->store->path, (int)auth->dns.len, auth->dns.ptr);
 
                        /* dump to the "dpapi" sink */
                        line[nmsg++] = ist("acme deploy ");