drm/amd/pm: Use driver table structure in smuv11

Use driver table structure for gpu metrics in smuv11. The default cache
interval is set at 5ms.

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Asad Kamal <asad.kamal@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
index 1aa7d653df7d3f22f5287e764ffadd31290cfe44..3416f3dddd14873283146f393c7f243dab4df8e7 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
+++ b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
@@ -41,6 +41,8 @@
 #define SMU_CUSTOM_FAN_SPEED_RPM     (1 << 1)
 #define SMU_CUSTOM_FAN_SPEED_PWM     (1 << 2)
 
+#define SMU_GPU_METRICS_CACHE_INTERVAL 5
+
 // Power Throttlers
 #define SMU_THROTTLER_PPT0_BIT                 0
 #define SMU_THROTTLER_PPT1_BIT                 1

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
index 0667a3f9282a5e66654ccab77b9c8734baf6b45b..81241976b53c62d2e0ff8b76e9bbbeded81e1cf2 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
@@ -248,6 +248,7 @@ static int arcturus_tables_init(struct smu_context *smu)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_table *tables = smu_table->tables;
+       int ret;
 
        SMU_TABLE_INIT(tables, SMU_TABLE_PPTABLE, sizeof(PPTable_t),
                       PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
@@ -270,11 +271,12 @@ static int arcturus_tables_init(struct smu_context *smu)
                return -ENOMEM;
        smu_table->metrics_time = 0;
 
-       smu_table->gpu_metrics_table_size = sizeof(struct gpu_metrics_v1_3);
-       smu_table->gpu_metrics_table = kzalloc(smu_table->gpu_metrics_table_size, GFP_KERNEL);
-       if (!smu_table->gpu_metrics_table) {
+       ret = smu_driver_table_init(smu, SMU_DRIVER_TABLE_GPU_METRICS,
+                                   sizeof(struct gpu_metrics_v1_3),
+                                   SMU_GPU_METRICS_CACHE_INTERVAL);
+       if (ret) {
                kfree(smu_table->metrics_table);
-               return -ENOMEM;
+               return ret;
        }
 
        return 0;
@@ -1812,9 +1814,9 @@ static uint16_t arcturus_get_current_pcie_link_speed(struct smu_context *smu)
 static ssize_t arcturus_get_gpu_metrics(struct smu_context *smu,
                                        void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v1_3 *gpu_metrics =
-               (struct gpu_metrics_v1_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v1_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_t metrics;
        int ret = 0;
 
@@ -1868,6 +1870,8 @@ static ssize_t arcturus_get_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v1_3);
 }
 

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
index e0e829ea65790a6b0c2be94984ab9c27ae70b32f..51f0e299b840c820d789843c732cf5272be162ad 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
@@ -88,6 +88,7 @@ static int cyan_skillfish_tables_init(struct smu_context *smu)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_table *tables = smu_table->tables;
+       int ret;
 
        SMU_TABLE_INIT(tables, SMU_TABLE_SMU_METRICS,
                                sizeof(SmuMetrics_t),
@@ -98,9 +99,10 @@ static int cyan_skillfish_tables_init(struct smu_context *smu)
        if (!smu_table->metrics_table)
                goto err0_out;
 
-       smu_table->gpu_metrics_table_size = sizeof(struct gpu_metrics_v2_2);
-       smu_table->gpu_metrics_table = kzalloc(smu_table->gpu_metrics_table_size, GFP_KERNEL);
-       if (!smu_table->gpu_metrics_table)
+       ret = smu_driver_table_init(smu, SMU_DRIVER_TABLE_GPU_METRICS,
+                                   sizeof(struct gpu_metrics_v2_2),
+                                   SMU_GPU_METRICS_CACHE_INTERVAL);
+       if (ret)
                goto err1_out;
 
        smu_table->metrics_time = 0;
@@ -108,7 +110,6 @@ static int cyan_skillfish_tables_init(struct smu_context *smu)
        return 0;
 
 err1_out:
-       smu_table->gpu_metrics_table_size = 0;
        kfree(smu_table->metrics_table);
 err0_out:
        return -ENOMEM;
@@ -383,9 +384,9 @@ static bool cyan_skillfish_is_dpm_running(struct smu_context *smu)
 static ssize_t cyan_skillfish_get_gpu_metrics(struct smu_context *smu,
                                                void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v2_2 *gpu_metrics =
-               (struct gpu_metrics_v2_2 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v2_2 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_t metrics;
        int i, ret = 0;
 
@@ -432,6 +433,8 @@ static ssize_t cyan_skillfish_get_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v2_2);
 }
 

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
index 4896200a0bd9161cb321f1aeb2ca8c78e3be4244..74f24618485a42eec91e6f141a1b88e5989f6acc 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
@@ -495,8 +495,8 @@ static int navi10_tables_init(struct smu_context *smu)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_table *tables = smu_table->tables;
-       struct smu_table *dummy_read_1_table =
-                       &smu_table->dummy_read_1_table;
+       struct smu_table *dummy_read_1_table = &smu_table->dummy_read_1_table;
+       int ret;
 
        SMU_TABLE_INIT(tables, SMU_TABLE_PPTABLE, sizeof(PPTable_t),
                       PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
@@ -526,9 +526,10 @@ static int navi10_tables_init(struct smu_context *smu)
                goto err0_out;
        smu_table->metrics_time = 0;
 
-       smu_table->gpu_metrics_table_size = sizeof(struct gpu_metrics_v1_3);
-       smu_table->gpu_metrics_table = kzalloc(smu_table->gpu_metrics_table_size, GFP_KERNEL);
-       if (!smu_table->gpu_metrics_table)
+       ret = smu_driver_table_init(smu, SMU_DRIVER_TABLE_GPU_METRICS,
+                                   sizeof(struct gpu_metrics_v1_3),
+                                   SMU_GPU_METRICS_CACHE_INTERVAL);
+       if (ret)
                goto err1_out;
 
        smu_table->watermarks_table = kzalloc(sizeof(Watermarks_t), GFP_KERNEL);
@@ -545,7 +546,7 @@ static int navi10_tables_init(struct smu_context *smu)
 err3_out:
        kfree(smu_table->watermarks_table);
 err2_out:
-       kfree(smu_table->gpu_metrics_table);
+       smu_driver_table_fini(smu, SMU_DRIVER_TABLE_GPU_METRICS);
 err1_out:
        kfree(smu_table->metrics_table);
 err0_out:
@@ -2713,7 +2714,8 @@ static ssize_t navi10_get_legacy_gpu_metrics(struct smu_context *smu,
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v1_3 *gpu_metrics =
-               (struct gpu_metrics_v1_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v1_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_legacy_t metrics;
        int ret = 0;
 
@@ -2775,6 +2777,8 @@ static ssize_t navi10_get_legacy_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v1_3);
 }
 
@@ -2921,7 +2925,8 @@ static ssize_t navi10_get_gpu_metrics(struct smu_context *smu,
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v1_3 *gpu_metrics =
-               (struct gpu_metrics_v1_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v1_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_t metrics;
        int ret = 0;
 
@@ -2985,6 +2990,8 @@ static ssize_t navi10_get_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v1_3);
 }
 
@@ -2993,7 +3000,8 @@ static ssize_t navi12_get_legacy_gpu_metrics(struct smu_context *smu,
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v1_3 *gpu_metrics =
-               (struct gpu_metrics_v1_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v1_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_NV12_legacy_t metrics;
        int ret = 0;
 
@@ -3060,6 +3068,8 @@ static ssize_t navi12_get_legacy_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v1_3);
 }
 
@@ -3068,7 +3078,8 @@ static ssize_t navi12_get_gpu_metrics(struct smu_context *smu,
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v1_3 *gpu_metrics =
-               (struct gpu_metrics_v1_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v1_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_NV12_t metrics;
        int ret = 0;
 
@@ -3137,6 +3148,8 @@ static ssize_t navi12_get_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v1_3);
 }
 

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index 108e8b3027eac84771efa6b9b8719b9947641b60..3f3947dc52a904eb82675c5e63f09752fa6c229d 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -533,6 +533,7 @@ static int sienna_cichlid_tables_init(struct smu_context *smu)
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_table *tables = smu_table->tables;
        int table_size;
+       int ret;
 
        table_size = get_table_size(smu);
        SMU_TABLE_INIT(tables, SMU_TABLE_PPTABLE, table_size,
@@ -560,9 +561,10 @@ static int sienna_cichlid_tables_init(struct smu_context *smu)
                goto err0_out;
        smu_table->metrics_time = 0;
 
-       smu_table->gpu_metrics_table_size = sizeof(struct gpu_metrics_v1_3);
-       smu_table->gpu_metrics_table = kzalloc(smu_table->gpu_metrics_table_size, GFP_KERNEL);
-       if (!smu_table->gpu_metrics_table)
+       ret = smu_driver_table_init(smu, SMU_DRIVER_TABLE_GPU_METRICS,
+                                   sizeof(struct gpu_metrics_v1_3),
+                                   SMU_GPU_METRICS_CACHE_INTERVAL);
+       if (ret)
                goto err1_out;
 
        smu_table->watermarks_table = kzalloc(sizeof(Watermarks_t), GFP_KERNEL);
@@ -585,7 +587,7 @@ err4_out:
 err3_out:
        kfree(smu_table->watermarks_table);
 err2_out:
-       kfree(smu_table->gpu_metrics_table);
+       smu_driver_table_fini(smu, SMU_DRIVER_TABLE_GPU_METRICS);
 err1_out:
        kfree(smu_table->metrics_table);
 err0_out:
@@ -2632,9 +2634,9 @@ static void sienna_cichlid_i2c_control_fini(struct smu_context *smu)
 static ssize_t sienna_cichlid_get_gpu_metrics(struct smu_context *smu,
                                              void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v1_3 *gpu_metrics =
-               (struct gpu_metrics_v1_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v1_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetricsExternal_t metrics_external;
        SmuMetrics_t *metrics =
                &(metrics_external.SmuMetrics);
@@ -2783,6 +2785,8 @@ static ssize_t sienna_cichlid_get_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v1_3);
 }
 

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
index b8d9cc5fe3d1971b56070d9e3bd835854f865840..3d03010abcc1b1569b6f28e6c2e76e2a1651df08 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
@@ -428,14 +428,13 @@ int smu_v11_0_fini_smc_tables(struct smu_context *smu)
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_dpm_context *smu_dpm = &smu->smu_dpm;
 
-       kfree(smu_table->gpu_metrics_table);
+       smu_driver_table_fini(smu, SMU_DRIVER_TABLE_GPU_METRICS);
        kfree(smu_table->user_overdrive_table);
        kfree(smu_table->boot_overdrive_table);
        kfree(smu_table->overdrive_table);
        kfree(smu_table->max_sustainable_clocks);
        kfree(smu_table->driver_pptable);
        kfree(smu_table->clocks_table);
-       smu_table->gpu_metrics_table = NULL;
        smu_table->user_overdrive_table = NULL;
        smu_table->boot_overdrive_table = NULL;
        smu_table->overdrive_table = NULL;

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 34b3f8680a2ccde7b94ca097b43e87b7f1a98ecd..65a0302ce875628aff11c6df81c1516ddcceb18b 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -225,6 +225,7 @@ static int vangogh_tables_init(struct smu_context *smu)
 {
        struct smu_table_context *smu_table = &smu->smu_table;
        struct smu_table *tables = smu_table->tables;
+       int ret;
 
        SMU_TABLE_INIT(tables, SMU_TABLE_WATERMARKS, sizeof(Watermarks_t),
                       PAGE_SIZE, AMDGPU_GEM_DOMAIN_VRAM);
@@ -242,11 +243,12 @@ static int vangogh_tables_init(struct smu_context *smu)
                goto err0_out;
        smu_table->metrics_time = 0;
 
-       smu_table->gpu_metrics_table_size = sizeof(struct gpu_metrics_v2_2);
-       smu_table->gpu_metrics_table_size = max(smu_table->gpu_metrics_table_size, sizeof(struct gpu_metrics_v2_3));
-       smu_table->gpu_metrics_table_size = max(smu_table->gpu_metrics_table_size, sizeof(struct gpu_metrics_v2_4));
-       smu_table->gpu_metrics_table = kzalloc(smu_table->gpu_metrics_table_size, GFP_KERNEL);
-       if (!smu_table->gpu_metrics_table)
+       ret = smu_driver_table_init(smu, SMU_DRIVER_TABLE_GPU_METRICS,
+                                   max3(sizeof(struct gpu_metrics_v2_2),
+                                        sizeof(struct gpu_metrics_v2_3),
+                                        sizeof(struct gpu_metrics_v2_4)),
+                                   SMU_GPU_METRICS_CACHE_INTERVAL);
+       if (ret)
                goto err1_out;
 
        smu_table->watermarks_table = kzalloc(sizeof(Watermarks_t), GFP_KERNEL);
@@ -262,7 +264,7 @@ static int vangogh_tables_init(struct smu_context *smu)
 err3_out:
        kfree(smu_table->watermarks_table);
 err2_out:
-       kfree(smu_table->gpu_metrics_table);
+       smu_driver_table_fini(smu, SMU_DRIVER_TABLE_GPU_METRICS);
 err1_out:
        kfree(smu_table->metrics_table);
 err0_out:
@@ -1653,9 +1655,9 @@ static int vangogh_set_watermarks_table(struct smu_context *smu,
 static ssize_t vangogh_get_legacy_gpu_metrics_v2_3(struct smu_context *smu,
                                      void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v2_3 *gpu_metrics =
-               (struct gpu_metrics_v2_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v2_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_legacy_t metrics;
        int ret = 0;
 
@@ -1704,15 +1706,17 @@ static ssize_t vangogh_get_legacy_gpu_metrics_v2_3(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v2_3);
 }
 
 static ssize_t vangogh_get_legacy_gpu_metrics(struct smu_context *smu,
                                      void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v2_2 *gpu_metrics =
-               (struct gpu_metrics_v2_2 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v2_2 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_legacy_t metrics;
        int ret = 0;
 
@@ -1761,15 +1765,17 @@ static ssize_t vangogh_get_legacy_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v2_2);
 }
 
 static ssize_t vangogh_get_gpu_metrics_v2_3(struct smu_context *smu,
                                      void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v2_3 *gpu_metrics =
-               (struct gpu_metrics_v2_3 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v2_3 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_t metrics;
        int ret = 0;
 
@@ -1832,6 +1838,8 @@ static ssize_t vangogh_get_gpu_metrics_v2_3(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v2_3);
 }
 
@@ -1839,9 +1847,9 @@ static ssize_t vangogh_get_gpu_metrics_v2_4(struct smu_context *smu,
                                            void **table)
 {
        SmuMetrics_t metrics;
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v2_4 *gpu_metrics =
-                               (struct gpu_metrics_v2_4 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v2_4 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        int ret = 0;
 
        ret = smu_cmn_get_metrics_table(smu, &metrics, true);
@@ -1912,15 +1920,17 @@ static ssize_t vangogh_get_gpu_metrics_v2_4(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v2_4);
 }
 
 static ssize_t vangogh_get_gpu_metrics(struct smu_context *smu,
                                      void **table)
 {
-       struct smu_table_context *smu_table = &smu->smu_table;
        struct gpu_metrics_v2_2 *gpu_metrics =
-               (struct gpu_metrics_v2_2 *)smu_table->gpu_metrics_table;
+               (struct gpu_metrics_v2_2 *)smu_driver_table_ptr(
+                       smu, SMU_DRIVER_TABLE_GPU_METRICS);
        SmuMetrics_t metrics;
        int ret = 0;
 
@@ -1976,6 +1986,8 @@ static ssize_t vangogh_get_gpu_metrics(struct smu_context *smu,
 
        *table = (void *)gpu_metrics;
 
+       smu_driver_table_update_cache_time(smu, SMU_DRIVER_TABLE_GPU_METRICS);
+
        return sizeof(struct gpu_metrics_v2_2);
 }