]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virStorageVolObjEndAPI: Remove
authorTim Wiederhake <twiederh@redhat.com>
Mon, 11 Apr 2022 11:36:44 +0000 (13:36 +0200)
committerTim Wiederhake <twiederh@redhat.com>
Thu, 14 Apr 2022 17:03:42 +0000 (19:03 +0200)
This allows a later patch to replace virObjectLock/Unlock
pairs with automatic mutex management code.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/virstorageobj.c

index 1ecf35640c3e9b82eab6e9ba44955312e06b5727..108ae0aeb134274b40d8ff367a523052c2fda4eb 100644 (file)
@@ -138,17 +138,6 @@ virStorageVolObjNew(void)
 }
 
 
-static void
-virStorageVolObjEndAPI(virStorageVolObj **obj)
-{
-    if (!*obj)
-        return;
-
-    virObjectUnlock(*obj);
-    g_clear_pointer(obj, virObjectUnref);
-}
-
-
 static void
 virStorageVolObjDispose(void *opaque)
 {
@@ -660,7 +649,8 @@ virStoragePoolObjAddVol(virStoragePoolObj *obj,
 
     volobj->voldef = voldef;
 
-    virStorageVolObjEndAPI(&volobj);
+    virObjectUnlock(volobj);
+    virObjectUnref(volobj);
     virObjectRWUnlock(volumes);
     return 0;
 }
@@ -689,8 +679,8 @@ virStoragePoolObjRemoveVol(virStoragePoolObj *obj,
     g_hash_table_remove(volumes->objsKey, voldef->key);
     g_hash_table_remove(volumes->objsName, voldef->name);
     g_hash_table_remove(volumes->objsPath, voldef->target.path);
-    virStorageVolObjEndAPI(&volobj);
-
+    virObjectUnlock(volobj);
+    virObjectUnref(volobj);
     virObjectRWUnlock(volumes);
 }