]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
output/anomaly: Use helpers for string output
authorJeff Lucovsky <jeff@lucovsky.org>
Fri, 12 Jun 2020 14:13:10 +0000 (10:13 -0400)
committerVictor Julien <victor@inliniac.net>
Sun, 28 Jun 2020 10:54:34 +0000 (12:54 +0200)
src/output-json-anomaly.c

index e9980446b345c3ec5be41238f5ba2140387771a6..3f2fec40cbe355b8d26c0c49dfef850697cd90ae 100644 (file)
@@ -115,12 +115,14 @@ static int AnomalyDecodeEventJson(ThreadVars *tv, JsonAnomalyLogThread *aft,
 
         if (event_code < DECODE_EVENT_MAX) {
             const char *event = DEvents[event_code].event_name;
-            jb_set_string(js, "type",
-                                EVENT_IS_DECODER_PACKET_ERROR(event_code) ?
-                                    "decode" : "stream");
+            if (EVENT_IS_DECODER_PACKET_ERROR(event_code)) {
+                JB_SET_STRING(js, "type", "decode");
+            } else {
+                JB_SET_STRING(js, "type", "stream");
+            }
             jb_set_string(js, "event", event);
         } else {
-            jb_set_string(js, "type", "unknown");
+            JB_SET_STRING(js, "type", "unknown");
             jb_set_uint(js, "code", event_code);
         }
 
@@ -180,10 +182,10 @@ static int AnomalyAppLayerDecoderEventJson(JsonAnomalyLogThread *aft,
                                                event_code, &event_name, &event_type);
         }
         if (r == 0) {
-            jb_set_string(js, "type", "applayer");
+            JB_SET_STRING(js, "type", "applayer");
             jb_set_string(js, "event", event_name);
         } else {
-            jb_set_string(js, "type", "unknown");
+            JB_SET_STRING(js, "type", "unknown");
             jb_set_uint(js, "code", event_code);
         }