]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ipmi_si: Use strstrip() to remove surrounding spaces
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 2 Apr 2021 17:43:32 +0000 (20:43 +0300)
committerCorey Minyard <cminyard@mvista.com>
Fri, 2 Apr 2021 17:53:36 +0000 (12:53 -0500)
Instead of home grown analogue, use strstrip() from the kernel library.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Message-Id: <20210402174334.13466-9-andriy.shevchenko@linux.intel.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_si_hotmod.c

index 4fbb4e18bae21310749696db8e85001520b3aee8..087f5eb1ebc0d396b4246967c30ca1ed196a0829 100644 (file)
@@ -185,24 +185,16 @@ static atomic_t hotmod_nr;
 
 static int hotmod_handler(const char *val, const struct kernel_param *kp)
 {
-       char *str = kstrdup(val, GFP_KERNEL), *curr, *next;
        int  rv;
        struct ipmi_plat_data h;
-       unsigned int len;
-       int ival;
+       char *str, *curr, *next;
 
+       str = kstrdup(val, GFP_KERNEL);
        if (!str)
                return -ENOMEM;
 
        /* Kill any trailing spaces, as we can get a "\n" from echo. */
-       len = strlen(str);
-       ival = len - 1;
-       while ((ival >= 0) && isspace(str[ival])) {
-               str[ival] = '\0';
-               ival--;
-       }
-
-       for (curr = str; curr; curr = next) {
+       for (curr = strstrip(str); curr; curr = next) {
                enum hotmod_op op;
 
                next = strchr(curr, ':');
@@ -235,7 +227,7 @@ static int hotmod_handler(const char *val, const struct kernel_param *kp)
                                put_device(dev);
                }
        }
-       rv = len;
+       rv = strlen(val);
 out:
        kfree(str);
        return rv;