]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Use the ternary operator in a few more places (#32303)
authorXhmikosR <xhmikosr@gmail.com>
Fri, 11 Dec 2020 13:47:34 +0000 (15:47 +0200)
committerGitHub <noreply@github.com>
Fri, 11 Dec 2020 13:47:34 +0000 (15:47 +0200)
js/src/carousel.js
js/src/tab.js

index e1432d924b1c5015a4850c074cd94e45d0be7b4a..b9257bcc9df3f8db1bcd1b0cd8e6830fb93e0d13 100644 (file)
@@ -431,19 +431,9 @@ class Carousel extends BaseComponent {
     const nextElementIndex = this._getItemIndex(nextElement)
     const isCycling = Boolean(this._interval)
 
-    let directionalClassName
-    let orderClassName
-    let eventDirectionName
-
-    if (direction === DIRECTION_NEXT) {
-      directionalClassName = CLASS_NAME_START
-      orderClassName = CLASS_NAME_NEXT
-      eventDirectionName = DIRECTION_LEFT
-    } else {
-      directionalClassName = CLASS_NAME_END
-      orderClassName = CLASS_NAME_PREV
-      eventDirectionName = DIRECTION_RIGHT
-    }
+    const directionalClassName = direction === DIRECTION_NEXT ? CLASS_NAME_START : CLASS_NAME_END
+    const orderClassName = direction === DIRECTION_NEXT ? CLASS_NAME_NEXT : CLASS_NAME_PREV
+    const eventDirectionName = direction === DIRECTION_NEXT ? DIRECTION_LEFT : DIRECTION_RIGHT
 
     if (nextElement && nextElement.classList.contains(CLASS_NAME_ACTIVE)) {
       this._isSliding = false
index c882ecd16abc77f6c5f5a408b6942c4a2792eadd..f1b17ac79797d9440d0c959d1fc0407c029f558b 100644 (file)
@@ -81,13 +81,11 @@ class Tab extends BaseComponent {
       previous = previous[previous.length - 1]
     }
 
-    let hideEvent = null
-
-    if (previous) {
-      hideEvent = EventHandler.trigger(previous, EVENT_HIDE, {
+    const hideEvent = previous ?
+      EventHandler.trigger(previous, EVENT_HIDE, {
         relatedTarget: this._element
-      })
-    }
+      }) :
+      null
 
     const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, {
       relatedTarget: previous