Bug 338375: Use Bugzilla->params everywhere instead of Param().

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave

diff --git a/Bugzilla/Attachment.pm b/Bugzilla/Attachment.pm
index 0ed77974f87693d407455e3098cf93e2ed8048dc..f012c3f2e75468ba65ae363fadfb91754d9ddfed 100644 (file)
--- a/Bugzilla/Attachment.pm
+++ b/Bugzilla/Attachment.pm
@@ -50,7 +50,6 @@ that users upload to the Bugzilla server.
 use Bugzilla::Constants;
 use Bugzilla::Error;
 use Bugzilla::Flag;
-use Bugzilla::Config;
 use Bugzilla::User;
 use Bugzilla::Util qw(trick_taint);
 

diff --git a/Bugzilla/Auth.pm b/Bugzilla/Auth.pm
index b6d378a435f9f7ab84c5d810643fdf9a942cae9d..40a0917efa0838c8967df55cfc3feef07c0dee45 100644 (file)
--- a/Bugzilla/Auth.pm
+++ b/Bugzilla/Auth.pm
@@ -32,7 +32,6 @@ use fields qw(
 
 use Bugzilla::Constants;
 use Bugzilla::Error;
-use Bugzilla::Config;
 use Bugzilla::Auth::Login::Stack;
 use Bugzilla::Auth::Verify::Stack;
 use Bugzilla::Auth::Persist::Cookie;

diff --git a/Bugzilla/Auth/Login/CGI.pm b/Bugzilla/Auth/Login/CGI.pm
index d0c29d8aa8263a7eef853b1d844f3f2c5746c50f..033cb992b655e6a6af867b23ba2847936b04928d 100644 (file)
--- a/Bugzilla/Auth/Login/CGI.pm
+++ b/Bugzilla/Auth/Login/CGI.pm
@@ -33,7 +33,6 @@ use strict;
 use base qw(Bugzilla::Auth::Login);
 use constant user_can_create_account => 1;
 
-use Bugzilla::Config;
 use Bugzilla::Constants;
 use Bugzilla::Util;
 use Bugzilla::Error;

diff --git a/Bugzilla/Auth/Login/Env.pm b/Bugzilla/Auth/Login/Env.pm
index f9837b3e67014ab54b437ae761d9ebe0739e12dd..180e79ba7cf1ce23d81ba2b38215a81f82b317e9 100644 (file)
--- a/Bugzilla/Auth/Login/Env.pm
+++ b/Bugzilla/Auth/Login/Env.pm
@@ -24,7 +24,6 @@ package Bugzilla::Auth::Login::Env;
 use strict;
 use base qw(Bugzilla::Auth::Login);
 
-use Bugzilla::Config;
 use Bugzilla::Constants;
 use Bugzilla::Error;
 

diff --git a/Bugzilla/Auth/Persist/Cookie.pm b/Bugzilla/Auth/Persist/Cookie.pm
index 3d8599c188ca86764e3a4b1837a94efa74f73136..3faa892aeb7d93f8b1d1b428b9cf1eeb0935611b 100644 (file)
--- a/Bugzilla/Auth/Persist/Cookie.pm
+++ b/Bugzilla/Auth/Persist/Cookie.pm
@@ -32,7 +32,6 @@ package Bugzilla::Auth::Persist::Cookie;
 use strict;
 use fields qw();
 
-use Bugzilla::Config;
 use Bugzilla::Constants;
 use Bugzilla::Util;
 use Bugzilla::Token;

diff --git a/Bugzilla/Auth/Verify/LDAP.pm b/Bugzilla/Auth/Verify/LDAP.pm
index 7136195893ed91cb06463cec53d660ebe3b18641..9f050d854924b0f526c66742b80bcec6e8e8c6ad 100644 (file)
--- a/Bugzilla/Auth/Verify/LDAP.pm
+++ b/Bugzilla/Auth/Verify/LDAP.pm
@@ -35,7 +35,6 @@ use fields qw(
     ldap
 );
 
-use Bugzilla::Config;
 use Bugzilla::Constants;
 use Bugzilla::Error;
 

diff --git a/Bugzilla/Bug.pm b/Bugzilla/Bug.pm
index 72ca270930b2873f99442bfaa8be3e3f5383b5c4..64da19af493a36e7065d47d9f1fa1aeab4691701 100755 (executable)
--- a/Bugzilla/Bug.pm
+++ b/Bugzilla/Bug.pm
@@ -33,7 +33,6 @@ use strict;
 use CGI::Carp qw(fatalsToBrowser);
 
 use Bugzilla::Attachment;
-use Bugzilla::Config;
 use Bugzilla::Constants;
 use Bugzilla::Field;
 use Bugzilla::Flag;

diff --git a/Bugzilla/BugMail.pm b/Bugzilla/BugMail.pm
index dc6efc7351f555fffc5a1492f8afec8e924ab6bb..ddcf4791e31f5a531891b7fb39b10416f8b10395 100644 (file)
--- a/Bugzilla/BugMail.pm
+++ b/Bugzilla/BugMail.pm
@@ -35,7 +35,6 @@ package Bugzilla::BugMail;
 use Bugzilla::Error;
 use Bugzilla::User;
 use Bugzilla::Constants;
-use Bugzilla::Config;
 use Bugzilla::Util;
 use Bugzilla::Bug;
 use Bugzilla::Product;

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index c4a23f9cbe1315856e4900b40d0235c729db3df4..57c60dbb03c1a7f26be6f955ba97b68dcfd0a41d 100644 (file)
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -35,9 +35,6 @@ use strict;
 use base qw(Exporter);
 use Bugzilla::Constants;
 
-# Module stuff
-@Bugzilla::Config::EXPORT = qw(Param);
-
 # Don't export localvars by default - people should have to explicitly
 # ask for it, as a (probably futile) attempt to stop code using it
 # when it shouldn't
@@ -92,28 +89,6 @@ sub param_panels {
     return @param_panels;
 }
 
-sub Param {
-    my ($param) = @_;
-
-    _load_params unless %params;
-    my %param_values = %{Bugzilla->params};
-
-    # By this stage, the param must be in the hash
-    die "Can't find param named $param" unless (exists $params{$param});
-
-    # When module startup code runs (which is does even via -c, when using
-    # |use|), we may try to grab params which don't exist yet. This affects
-    # tests, so have this as a fallback for the -c case
-    return $params{$param}->{default} 
-        if ($^C && not exists $param_values{$param});
-
-    # If we have a value for the param, return it
-    return $param_values{$param} if exists $param_values{$param};
-
-    # Else error out
-    die "No value for param $param (try running checksetup.pl again)";
-}
-
 sub SetParam {
     my ($name, $value) = @_;
 
@@ -277,11 +252,6 @@ Bugzilla::Config - Configuration parameters for Bugzilla
 
 =head1 SYNOPSIS
 
-  # Getting parameters
-  use Bugzilla::Config;
-
-  my $fooSetting = Bugzilla->params->{'foo'};
-
   # Administration functions
   use Bugzilla::Config qw(:admin);
 
@@ -305,11 +275,6 @@ Parameters can be set, retrieved, and updated.
 
 =over 4
 
-=item C<Bugzilla->params->{$name}>
-
-Returns the Param with the specified name. Either a string, or, in the case
-of multiple-choice parameters, an array reference.
-
 =item C<SetParam($name, $value)>
 
 Sets the param named $name to $value. Values are checked using the checker

diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index 3d30dd7781fd8488f2448dab76b29932c41d7454..044aa3dea29707caa2df538453bfdfac3b26d5e2 100644 (file)
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -35,7 +35,7 @@ use DBI;
 # Inherit the DB class from DBI::db.
 use base qw(DBI::db);
 
-use Bugzilla::Config qw(:DEFAULT :db);
+use Bugzilla::Config qw(:db);
 use Bugzilla::Constants;
 use Bugzilla::Util;
 use Bugzilla::Error;

diff --git a/Bugzilla/Flag.pm b/Bugzilla/Flag.pm
index 8646e72ac684d727d7ae8b652512bdc18f51f102..50721f159d2d1cf5a3a4fa2f3199d79672763ffe 100644 (file)
--- a/Bugzilla/Flag.pm
+++ b/Bugzilla/Flag.pm
@@ -61,7 +61,6 @@ package Bugzilla::Flag;
 
 use Bugzilla::FlagType;
 use Bugzilla::User;
-use Bugzilla::Config;
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Mailer;

diff --git a/Bugzilla/FlagType.pm b/Bugzilla/FlagType.pm
index 078f6de71e38332bf2bcfd2f69b18a6fdac0c913..ce4f31e687befde0c49532403d7b5ee492375753 100644 (file)
--- a/Bugzilla/FlagType.pm
+++ b/Bugzilla/FlagType.pm
@@ -59,7 +59,6 @@ use Bugzilla::User;
 
 use Bugzilla::Error;
 use Bugzilla::Util;
-use Bugzilla::Config;
 
 ######################################################################
 # Global Variables

diff --git a/Bugzilla/Mailer.pm b/Bugzilla/Mailer.pm
index 9f51c71e017ac661a4d31d0d4d283d98c84a8000..15df6bddd40d6a224c799edab1c23bc5ee1ad77d 100644 (file)
--- a/Bugzilla/Mailer.pm
+++ b/Bugzilla/Mailer.pm
@@ -37,7 +37,6 @@ use base qw(Exporter);
 @Bugzilla::Mailer::EXPORT = qw(MessageToMTA);
 
 use Bugzilla::Constants;
-use Bugzilla::Config;
 use Bugzilla::Util;
 
 use Mail::Header;

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index f9bf553884c3fa3f2654da7917639f659f8a1fdf..e8da89204f080c59becf890c269a977d4e0df9fc 100644 (file)
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -34,7 +34,6 @@ package Bugzilla::Search;
 use base qw(Exporter);
 @Bugzilla::Search::EXPORT = qw(IsValidQueryType);
 
-use Bugzilla::Config;
 use Bugzilla::Error;
 use Bugzilla::Util;
 use Bugzilla::Constants;

diff --git a/Bugzilla/Search/Quicksearch.pm b/Bugzilla/Search/Quicksearch.pm
index 48b825318da9d02f71f1110138494f984d7e8a6e..eba9bac017abe57b9d68642af903a5220001dfd0 100644 (file)
--- a/Bugzilla/Search/Quicksearch.pm
+++ b/Bugzilla/Search/Quicksearch.pm
@@ -23,7 +23,6 @@ package Bugzilla::Search::Quicksearch;
 # Make it harder for us to do dangerous things in Perl.
 use strict;
 
-use Bugzilla::Config;
 use Bugzilla::Error;
 use Bugzilla::Constants;
 use Bugzilla::Keyword;

diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm
index 65d9375104597610110d8eb692b01abe3fc1ccea..6094d6499852889eadeda781eda3ce7cef84b702 100644 (file)
--- a/Bugzilla/Template.pm
+++ b/Bugzilla/Template.pm
@@ -35,7 +35,6 @@ package Bugzilla::Template;
 use strict;
 
 use Bugzilla::Constants;
-use Bugzilla::Config;
 use Bugzilla::Util;
 use Bugzilla::User;
 use Bugzilla::Error;
@@ -771,7 +770,7 @@ sub create {
         # Default variables for all templates
         VARIABLES => {
             # Function for retrieving global parameters.
-            'Param' => \&Bugzilla::Config::Param,
+            'Param' => sub { return Bugzilla->params->{$_[0]}; },
 
             # Function to create date strings
             'time2str' => \&Date::Format::time2str,

diff --git a/Bugzilla/Template/Plugin/Hook.pm b/Bugzilla/Template/Plugin/Hook.pm
index 6f744a8aa52ab0276969d77a25c3635733eff77e..a5eec820b23f0d0533e97dbe4b26fe857c6278d7 100644 (file)
--- a/Bugzilla/Template/Plugin/Hook.pm
+++ b/Bugzilla/Template/Plugin/Hook.pm
@@ -25,7 +25,6 @@ package Bugzilla::Template::Plugin::Hook;
 
 use strict;
 
-use Bugzilla::Config;
 use Bugzilla::Constants;
 use Bugzilla::Template;
 use Bugzilla::Util;

diff --git a/Bugzilla/Token.pm b/Bugzilla/Token.pm
index c2e11f5a3b08218d3796832d252a0883cc80e8d4..c570c34b16d3676b46c786bacda374e5255aed4e 100644 (file)
--- a/Bugzilla/Token.pm
+++ b/Bugzilla/Token.pm
@@ -29,7 +29,6 @@ use strict;
 # Bundle the functions in this file together into the "Bugzilla::Token" package.
 package Bugzilla::Token;
 
-use Bugzilla::Config;
 use Bugzilla::Error;
 use Bugzilla::Mailer;
 use Bugzilla::Util;

diff --git a/Bugzilla/User.pm b/Bugzilla/User.pm
index 1c30ce024f9096e6fbbfe369f0885409fdcca5c2..9977ca86c691fc4ec03005241c7bf8ca1de2cd78 100644 (file)
--- a/Bugzilla/User.pm
+++ b/Bugzilla/User.pm
@@ -40,7 +40,6 @@ use strict;
 # This module implements utilities for dealing with Bugzilla users.
 package Bugzilla::User;
 
-use Bugzilla::Config;
 use Bugzilla::Error;
 use Bugzilla::Util;
 use Bugzilla::Constants;

diff --git a/attachment.cgi b/attachment.cgi
index 3ed2984c4774e1e2d94e9c9a4c37be1dbbe1e980..fcbd100200e20ed452c4a332813f9088bd433c08 100755 (executable)
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -38,7 +38,7 @@ use strict;
 use lib qw(.);
 
 use Bugzilla;
-use Bugzilla::Config qw(:DEFAULT :localconfig);
+use Bugzilla::Config qw(:localconfig);
 use Bugzilla::Constants;
 use Bugzilla::Error;
 use Bugzilla::Flag; 

diff --git a/buglist.cgi b/buglist.cgi
index 0fcf13b8831a5af212a23682401da4ad81bb3dbc..937749d28a175db587d91c8422fc25770aa975dc 100755 (executable)
--- a/buglist.cgi
+++ b/buglist.cgi
@@ -38,7 +38,6 @@ use Bugzilla;
 use Bugzilla::Constants;
 use Bugzilla::Error;
 use Bugzilla::Util;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Search;
 use Bugzilla::Search::Quicksearch;
 use Bugzilla::User;

diff --git a/chart.cgi b/chart.cgi
index b40a8113e401cd60c33068057f8d508519dc8503..fd70258553bb31730d491339ff4f4ca1925e9de6 100755 (executable)
--- a/chart.cgi
+++ b/chart.cgi
@@ -47,7 +47,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Error;
 use Bugzilla::Util;
 use Bugzilla::Chart;

diff --git a/checksetup.pl b/checksetup.pl
index ba4efd0e4df4d1a76418bbff41b09cfd0d7233d1..fae29156961bf8a60962cfe0590e3e0610ce280d 100755 (executable)
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -517,7 +517,7 @@ BEGIN {
     $::ENV{'PATH'} = $env;
 
     require Bugzilla::Config;
-    import Bugzilla::Config qw(:DEFAULT :admin);
+    import Bugzilla::Config qw(:admin);
 }
 
 # 12/17/00 justdave@syndicomm.com - removed declarations of the localconfig

diff --git a/colchange.cgi b/colchange.cgi
index 6d737d5c742434c98a8321d8addb44ad2d32b2f6..3f06ca533e94e6e48b0a16438945a1f7f5e459cc 100755 (executable)
--- a/colchange.cgi
+++ b/colchange.cgi
@@ -27,7 +27,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Error;
 use Bugzilla::User;
 use Bugzilla::Keyword;

diff --git a/collectstats.pl b/collectstats.pl
index 2f76e544f3f122bedfa344ad1564e9db8629c1a7..0739d03122793373ab65b810338f5fd4cbdca587 100755 (executable)
--- a/collectstats.pl
+++ b/collectstats.pl
@@ -37,7 +37,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Search;
 use Bugzilla::User;

diff --git a/config.cgi b/config.cgi
index 3675a342fd4060cac620d37b9deeb2fdc4d6622c..2ebcea181679ae07228845dba8dd8818d21b6c85 100755 (executable)
--- a/config.cgi
+++ b/config.cgi
@@ -32,7 +32,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Error;
 use Bugzilla::Keyword;
 use Bugzilla::Bug;

diff --git a/contrib/bug_email.pl b/contrib/bug_email.pl
index 3cb796b7e61ddae7cd4e6e20931b7b4bffd4acaf..d2fc91b66c6cc7d47f73068866ecf8e77e199e72 100755 (executable)
--- a/contrib/bug_email.pl
+++ b/contrib/bug_email.pl
@@ -38,7 +38,7 @@
 #
 # You need to work with bug_email.pl the MIME::Parser installed.
 # 
-# $Id: bug_email.pl,v 1.43 2006/07/03 21:26:22 mkanat%bugzilla.org Exp $
+# $Id: bug_email.pl,v 1.44 2006/07/03 21:42:47 mkanat%bugzilla.org Exp $
 ###############################################################
 
 # 02/12/2000 (SML)
@@ -91,7 +91,6 @@ use lib "../";
 
 use Bugzilla;
 use BugzillaEmail;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Constants;
 use Bugzilla::Util;
 use Bugzilla::BugMail;

diff --git a/contrib/bugzilla_email_append.pl b/contrib/bugzilla_email_append.pl
index fef46f01b6975797df0d6187eb48c69a4b186538..4b2e53f209982ed89c9c8bd07ac48a2b30a51b71 100755 (executable)
--- a/contrib/bugzilla_email_append.pl
+++ b/contrib/bugzilla_email_append.pl
@@ -40,7 +40,6 @@ BEGIN {
 use Bugzilla;
 use Bugzilla::Constants;
 use BugzillaEmail;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::BugMail;
 
 my $dbh = Bugzilla->dbh;

diff --git a/contrib/merge-users.pl b/contrib/merge-users.pl
index 540b22fb95db7f72fdcc9a5de872cad0fba9fa8c..2458755e6f3e9c3b1175162bcf5c65fcf7e5dbf4 100644 (file)
--- a/contrib/merge-users.pl
+++ b/contrib/merge-users.pl
@@ -48,7 +48,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 
 use Getopt::Long;

diff --git a/contrib/sendbugmail.pl b/contrib/sendbugmail.pl
index 8537f66cea2ccfaa39176765bac935083fe4d134..ae282ca4a60e0b15bd7514d2ddbc06f7f0b064f8 100644 (file)
--- a/contrib/sendbugmail.pl
+++ b/contrib/sendbugmail.pl
@@ -4,7 +4,7 @@
 #
 # Nick Barnes, Ravenbrook Limited, 2004-04-01.
 #
-# $Id: sendbugmail.pl,v 1.6 2006/07/03 21:26:22 mkanat%bugzilla.org Exp $
+# $Id: sendbugmail.pl,v 1.7 2006/07/03 21:42:47 mkanat%bugzilla.org Exp $
 # 
 # Bugzilla email script for Bugzilla 2.17.4 and later.  Invoke this to send
 # bugmail for a bug which has been changed directly in the database.
@@ -17,7 +17,6 @@
 use lib qw(.);
 
 use Bugzilla;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::BugMail;
 use Bugzilla::User;

diff --git a/contrib/syncLDAP.pl b/contrib/syncLDAP.pl
index 4ddabacea571e250c4a7cb6a6bb054cb60b1270b..32d01f15046d247c1af59f9882985fedee997986 100755 (executable)
--- a/contrib/syncLDAP.pl
+++ b/contrib/syncLDAP.pl
@@ -26,7 +26,6 @@ use lib qw(.);
 
 use Net::LDAP;
 use Bugzilla;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::User;
 
 my $cgi = Bugzilla->cgi;

diff --git a/createaccount.cgi b/createaccount.cgi
index a0f1ed2c37a32f6471d3f035d2e49c74d6103c19..ab011f3366d990e899ba5bddbf89edede131ae81 100755 (executable)
--- a/createaccount.cgi
+++ b/createaccount.cgi
@@ -30,7 +30,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Error;
 use Bugzilla::User;
 use Bugzilla::BugMail;

diff --git a/duplicates.cgi b/duplicates.cgi
index 1de3fe15ce619cdfa8a7ac66e2313d3056b12e77..7934c5c8f1a6eee881c8edbd5470fcfc49a2ff83 100755 (executable)
--- a/duplicates.cgi
+++ b/duplicates.cgi
@@ -31,7 +31,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Search;

diff --git a/editclassifications.cgi b/editclassifications.cgi
index 23ac30d37c6273a17755378dc6e56455978d60da..70aa256fbd8d38634822f60a9a9ccf9c104bdd3f 100755 (executable)
--- a/editclassifications.cgi
+++ b/editclassifications.cgi
@@ -27,7 +27,6 @@ use Bugzilla;
 use Bugzilla::Constants;
 use Bugzilla::Util;
 use Bugzilla::Error;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Classification;
 
 my $cgi = Bugzilla->cgi;

diff --git a/editcomponents.cgi b/editcomponents.cgi
index 244e83e55e591f08780854a490e436652881c3f3..e66e95195fcb17c02a80eda67b2a32e28f89d1b1 100755 (executable)
--- a/editcomponents.cgi
+++ b/editcomponents.cgi
@@ -31,7 +31,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Series;
 use Bugzilla::Util;
 use Bugzilla::Error;

diff --git a/editgroups.cgi b/editgroups.cgi
index f511a68a6634ae917d3eb6478d6e5703260eacc7..39e78e9e6faf00d57792effc1144444f62bcb2c0 100755 (executable)
--- a/editgroups.cgi
+++ b/editgroups.cgi
@@ -29,7 +29,7 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT :admin);
+use Bugzilla::Config qw(:admin);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Group;

diff --git a/editparams.cgi b/editparams.cgi
index 27db4654fafe02704329e808eed701ed6d460c18..5ae2bcc2599dc4e0ea6692a0c8519ef16e32180e 100755 (executable)
--- a/editparams.cgi
+++ b/editparams.cgi
@@ -27,7 +27,7 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT :admin);
+use Bugzilla::Config qw(:admin);
 use Bugzilla::Config::Common;
 use Bugzilla::Util;
 use Bugzilla::Error;

diff --git a/editproducts.cgi b/editproducts.cgi
index 8a0dd5fe87c6a6c5c2989d7584ee9b952547d147..2d2f81009a3e9d1c6fb5b99a860ad6c78e602298 100755 (executable)
--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -36,7 +36,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Bug;

diff --git a/editusers.cgi b/editusers.cgi
index 42a7d6e3ab778ebbedac7c04c5fcfd95afa0ad45..86e2cf424e9fca5141d9407005a81958d00cfee0 100755 (executable)
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -25,7 +25,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::User;

diff --git a/editvalues.cgi b/editvalues.cgi
index c812c6c879980077d654de0cf8a7a0f332f7647b..013e82be787f7987994fdd1b16df02300e7ce69b 100755 (executable)
--- a/editvalues.cgi
+++ b/editvalues.cgi
@@ -25,7 +25,7 @@ use Bugzilla;
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT :admin);
+use Bugzilla::Config qw(:admin);
 
 # List of different tables that contain the changeable field values
 # (the old "enums.") Keep them in alphabetical order by their 

diff --git a/editwhines.cgi b/editwhines.cgi
index 282b66ddb443565ec176816b4b200c24e6ecd565..f0fddeb5b2a0b46bb7141f6862271f53cde43c3e 100755 (executable)
--- a/editwhines.cgi
+++ b/editwhines.cgi
@@ -31,7 +31,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::User;

diff --git a/enter_bug.cgi b/enter_bug.cgi
index 929e690c84318593be971635a9f9d287886af009..e5463b5011cba17da59d7096e925b1c407ce229d 100755 (executable)
--- a/enter_bug.cgi
+++ b/enter_bug.cgi
@@ -39,7 +39,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Bug;

diff --git a/importxml.pl b/importxml.pl
index 263508b373a1a4d7ca101a861e80211fb9602c1b..6ed2727ea47478394dd3780241c7a1d8d7de5f4e 100755 (executable)
--- a/importxml.pl
+++ b/importxml.pl
@@ -79,7 +79,6 @@ use Bugzilla::Version;
 use Bugzilla::Component;
 use Bugzilla::Milestone;
 use Bugzilla::FlagType;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::BugMail;
 use Bugzilla::Mailer;
 use Bugzilla::User;

diff --git a/index.cgi b/index.cgi
index 3a591a32c2587699b85d61db16b3da36cb0beae3..9c3b6be96774a6e81051c3b6dc5774339ae9b7f7 100755 (executable)
--- a/index.cgi
+++ b/index.cgi
@@ -33,7 +33,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Error;
 use Bugzilla::Update;
 

diff --git a/post_bug.cgi b/post_bug.cgi
index 702ff96a42e11be72e4130e3f4dd094c9fb95dc5..6dcc776a4a759d83f74b957040137b6ffef320d5 100755 (executable)
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -30,7 +30,6 @@ use lib qw(.);
 use Bugzilla;
 use Bugzilla::Attachment;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Bug;

diff --git a/process_bug.cgi b/process_bug.cgi
index ec2e8f5fdc362099ab259edc532ef7f176399070..fa34ae70959a63439a63eb73981dcb7c3ddb304c 100755 (executable)
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -45,7 +45,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Bug;
 use Bugzilla::Mailer;
 use Bugzilla::User;

diff --git a/query.cgi b/query.cgi
index 382fa37c4018c60cce549c06a05957003955fa74..9c2067d3e74a03ecca4dfec68e2eef328dc40d83 100755 (executable)
--- a/query.cgi
+++ b/query.cgi
@@ -31,7 +31,6 @@ use lib ".";
 use Bugzilla;
 use Bugzilla::Bug;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Search;
 use Bugzilla::User;
 use Bugzilla::Util;

diff --git a/quips.cgi b/quips.cgi
index c405e089c0866bb910ecfd3d8f12df579bd591b2..06b6b0dd819a25641d15f1dd6d23e28f450c84c7 100755 (executable)
--- a/quips.cgi
+++ b/quips.cgi
@@ -29,7 +29,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::User;

diff --git a/reports.cgi b/reports.cgi
index 09b8dc30e737e78f6dc08fe8ff7a4c11ef696bbe..6c7a4ea398581bdbe45d0cb601e756e6565b20df 100755 (executable)
--- a/reports.cgi
+++ b/reports.cgi
@@ -39,7 +39,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 

diff --git a/request.cgi b/request.cgi
index 9383c21081270270a995339c0aceb0c87cf0a666..3057eebd660d99092f8b49718a1c99248a2e8f06 100755 (executable)
--- a/request.cgi
+++ b/request.cgi
@@ -31,7 +31,6 @@ use strict;
 use lib qw(.);
 
 use Bugzilla;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Flag;

diff --git a/show_bug.cgi b/show_bug.cgi
index 9e322a75f7916e02a9b8d8604476e2e55d1b1206..a23621d78fd3d1d2710902aa0c11d775dd5b0a62 100755 (executable)
--- a/show_bug.cgi
+++ b/show_bug.cgi
@@ -26,7 +26,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Error;
 use Bugzilla::User;
 use Bugzilla::Keyword;

diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi
index 5b6c3195a1d6e950996118f3d7aa61ab419d539f..c797e2b125eaec5b8f0edfdaf9d465c55209198e 100755 (executable)
--- a/showdependencygraph.cgi
+++ b/showdependencygraph.cgi
@@ -29,7 +29,6 @@ use File::Temp;
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Bug;

diff --git a/summarize_time.cgi b/summarize_time.cgi
index 371e43f8142f44525d5d2e13d3570c12405093ad..7693c988a6607d587c14ced53e04740c6cbd2898 100755 (executable)
--- a/summarize_time.cgi
+++ b/summarize_time.cgi
@@ -25,7 +25,6 @@ use Date::Format;        # strftime
 
 use Bugzilla;
 use Bugzilla::Constants; # LOGIN_*
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Bug;       # EmitDependList
 use Bugzilla::Util;      # trim
 use Bugzilla::Error;

diff --git a/userprefs.cgi b/userprefs.cgi
index a07cff135133c11a2aa246643ee73b8c82866447..5c1a85e329fae912c6e5910f51dc814b817492ea 100755 (executable)
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -28,7 +28,6 @@ use lib qw(.);
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Search;
 use Bugzilla::Util;
 use Bugzilla::Error;

diff --git a/votes.cgi b/votes.cgi
index bbae0b7cb01e0f355d82e584f04512abc7f22dbe..7e72bfcd36bb0ac9dba43769569ec967975853b3 100755 (executable)
--- a/votes.cgi
+++ b/votes.cgi
@@ -29,7 +29,6 @@ use lib ".";
 
 use Bugzilla;
 use Bugzilla::Constants;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Util;
 use Bugzilla::Error;
 use Bugzilla::Bug;

diff --git a/whine.pl b/whine.pl
index 093b6e5e607bf7e2329e7a5634477f35058a65f9..8e60370a3571e78fc2e1638fc418c6f879aae338 100755 (executable)
--- a/whine.pl
+++ b/whine.pl
@@ -29,7 +29,6 @@ use strict;
 use lib ".";
 
 use Bugzilla;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Constants;
 use Bugzilla::Search;
 use Bugzilla::User;

diff --git a/whineatnews.pl b/whineatnews.pl
index 3276858e7b3f4ea46519ca2f07669a6063d8b24b..58099076972b11533944edbd52b34a416e6ed249 100755 (executable)
--- a/whineatnews.pl
+++ b/whineatnews.pl
@@ -31,7 +31,6 @@ use strict;
 use lib '.';
 
 use Bugzilla;
-use Bugzilla::Config qw(:DEFAULT);
 use Bugzilla::Mailer;
 use Bugzilla::Util;