vala: Set default_construction_method in semantic-analyzer check if required

Doing this in the parser is not reasonable while this is clearly a sematic
requirement.

diff --git a/vala/valaclass.vala b/vala/valaclass.vala
index 586fe287f86a6a23d33260404fdc38a6b6272b84..d7f148986332bce918da2296eb8c0beb76d5782f 100644 (file)
--- a/vala/valaclass.vala
+++ b/vala/valaclass.vala
@@ -524,6 +524,15 @@ public class Vala.Class : ObjectTypeSymbol {
 
                checked = true;
 
+               // ensure there is always a default construction method
+               if (default_construction_method == null
+                   && source_reference.file.file_type == SourceFileType.SOURCE) {
+                       var m = new CreationMethod (name, null, source_reference);
+                       m.access = (is_abstract ? SymbolAccessibility.PROTECTED : SymbolAccessibility.PUBLIC);
+                       m.body = new Block (source_reference);
+                       add_method (m);
+               }
+
                var old_source_file = context.analyzer.current_source_file;
                var old_symbol = context.analyzer.current_symbol;
 

diff --git a/vala/valaparser.vala b/vala/valaparser.vala
index e2ec7b4a1bbc3ec850c6b9b889ed6de21d4af7c8..48818a293b3ff9d6ed9917558313304a60d256f6 100644 (file)
--- a/vala/valaparser.vala
+++ b/vala/valaparser.vala
@@ -2658,15 +2658,6 @@ public class Vala.Parser : CodeVisitor {
 
                parse_declarations (cl);
 
-               // ensure there is always a default construction method
-               if (scanner.source_file.file_type == SourceFileType.SOURCE
-                   && cl.default_construction_method == null) {
-                       var m = new CreationMethod (cl.name, null, cl.source_reference);
-                       m.access = (cl.is_abstract ? SymbolAccessibility.PROTECTED : SymbolAccessibility.PUBLIC);
-                       m.body = new Block (cl.source_reference);
-                       cl.add_method (m);
-               }
-
                Symbol result = cl;
                while (sym != null) {
                        sym = sym.inner;