%@]$*$* Intel and their %@]$*$* stupid braindead assembler mnemonics!

It's not that I'm incompetent.  Honest.

Fix bug causing GDB attach (detach) to crash system on multithreaded
programs.  This bug has been in Valgrind all along.

git-svn-id: svn://svn.valgrind.org/valgrind/trunk@114

diff --git a/coregrind/vg_startup.S b/coregrind/vg_startup.S
index 485abee85f22790502f51e4d7abb9fda150c76f1..561642196b904777d4c369fb054922f9c6b4986b 100644 (file)
--- a/coregrind/vg_startup.S
+++ b/coregrind/vg_startup.S
@@ -184,9 +184,9 @@ extern void VG_(swizzle_esp_then_start_GDB) ( Addr m_eip_at_error,
 /*--- This is clearly not re-entrant! ---*/
 .data
 vg_ebp_saved_over_GDB_start:
-       .word   0
+       .long   0
 vg_esp_saved_over_GDB_start:
-       .word   0
+       .long   0
 .text
        
 .global VG_(swizzle_esp_then_start_GDB)        
@@ -202,7 +202,7 @@ VG_(swizzle_esp_then_start_GDB):
        movl    40(%esp), %ebx          # client %ESP
        movl    36(%esp), %ecx          # client %EIP
 
-       # Now thatn we dont need to refer to simulators stack any more,
+       # Now that we dont need to refer to simulators stack any more,
        # put %ESP into %esp
        movl    %ebx, %esp
 

diff --git a/vg_startup.S b/vg_startup.S
index 485abee85f22790502f51e4d7abb9fda150c76f1..561642196b904777d4c369fb054922f9c6b4986b 100644 (file)
--- a/vg_startup.S
+++ b/vg_startup.S
@@ -184,9 +184,9 @@ extern void VG_(swizzle_esp_then_start_GDB) ( Addr m_eip_at_error,
 /*--- This is clearly not re-entrant! ---*/
 .data
 vg_ebp_saved_over_GDB_start:
-       .word   0
+       .long   0
 vg_esp_saved_over_GDB_start:
-       .word   0
+       .long   0
 .text
        
 .global VG_(swizzle_esp_then_start_GDB)        
@@ -202,7 +202,7 @@ VG_(swizzle_esp_then_start_GDB):
        movl    40(%esp), %ebx          # client %ESP
        movl    36(%esp), %ecx          # client %EIP
 
-       # Now thatn we dont need to refer to simulators stack any more,
+       # Now that we dont need to refer to simulators stack any more,
        # put %ESP into %esp
        movl    %ebx, %esp