]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Do not stop testheaders.sh on the first error, to be compatible with
authorAlex Rousskov <rousskov@measurement-factory.com>
Wed, 7 Jul 2010 00:22:37 +0000 (18:22 -0600)
committerAlex Rousskov <rousskov@measurement-factory.com>
Wed, 7 Jul 2010 00:22:37 +0000 (18:22 -0600)
"make -k check".

If testheaders.sh stops on the first error, it becomes very difficult to
test your changes with "make check" when somebody else broke some other
code or when the checks reach src/cf_parser.h and fail.

TODO: stop on the first error unless running under "make -k check".

test-suite/testheaders.sh

index 457496a12eb6366d573d3abcddcbd6d564d8f16b..48f358fd02d4ae99f70acf94d2b704b84f17f37d 100755 (executable)
@@ -16,6 +16,8 @@ else
        dir="${2}"
 fi
 
+exitCode=0
+
 for f in `cd ${dir} && ls -1 *.h 2>/dev/null`; do
        echo -n "Testing ${dir}/${f} ..."
        hdr=`echo "${f}" | sed s/.h//`
@@ -32,11 +34,14 @@ for f in `cd ${dir} && ls -1 *.h 2>/dev/null`; do
        fi
        if [ ! -f testHeaderDeps_${hdr}.o ]; then
                rm testHeaders
-               exit 1
+               exitCode=1
+       else
+               echo "OK."
+               # unit-tests require an app to run.
+               # our most-recent object suits this purpose.
+               # let's link or some tests will fail
+               ${cc} ./testHeaderDeps_${hdr}.o -o ./testHeaders
        fi
-       echo "OK."
-       # unit-tests require an app to run.
-       # our most-recent object suits this purpose.
-       # let's link or some tests will fail
-       ${cc} ./testHeaderDeps_${hdr}.o -o ./testHeaders
 done
+
+exit $exitCode