]> git.ipfire.org Git - thirdparty/fastapi/sqlmodel.git/commitdiff
📝 Fix docs for Pydantic's fields using `le` (`lte` is invalid, use `le` ) (#207)
authorJerry Wu <jerry@ycwu.space>
Mon, 23 Oct 2023 16:28:51 +0000 (00:28 +0800)
committerGitHub <noreply@github.com>
Mon, 23 Oct 2023 16:28:51 +0000 (16:28 +0000)
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
14 files changed:
docs/tutorial/fastapi/limit-and-offset.md
docs_src/tutorial/fastapi/app_testing/tutorial001/main.py
docs_src/tutorial/fastapi/delete/tutorial001.py
docs_src/tutorial/fastapi/limit_and_offset/tutorial001.py
docs_src/tutorial/fastapi/relationships/tutorial001.py
docs_src/tutorial/fastapi/session_with_dependency/tutorial001.py
docs_src/tutorial/fastapi/teams/tutorial001.py
docs_src/tutorial/fastapi/update/tutorial001.py
tests/test_tutorial/test_fastapi/test_delete/test_tutorial001.py
tests/test_tutorial/test_fastapi/test_limit_and_offset/test_tutorial001.py
tests/test_tutorial/test_fastapi/test_relationships/test_tutorial001.py
tests/test_tutorial/test_fastapi/test_session_with_dependency/test_tutorial001.py
tests/test_tutorial/test_fastapi/test_teams/test_tutorial001.py
tests/test_tutorial/test_fastapi/test_update/test_tutorial001.py

index 92bbfc7ee0325436ff2f0d523b521a80d6b52198..8802f4ec99cbc0d58895896378ef311a6632387b 100644 (file)
@@ -42,7 +42,7 @@ We want to allow clients to set different `offset` and `limit` values.
 
 But we don't want them to be able to set a `limit` of something like `9999`, that's over `9000`! 😱
 
-So, to prevent it, we add additional validation to the `limit` query parameter, declaring that it has to be **l**ess **t**han or **e**qual to `100` with `lte=100`.
+So, to prevent it, we add additional validation to the `limit` query parameter, declaring that it has to be **l**ess than or **e**qual to `100` with `le=100`.
 
 This way, a client can decide to take fewer heroes if they want, but not more.
 
index d106c4ebab63e2ce65f89ab4f4657096eb36f110..3f0602e4b4f9b32aeeafebd20c137ffb78fb003a 100644 (file)
@@ -66,7 +66,7 @@ def read_heroes(
     *,
     session: Session = Depends(get_session),
     offset: int = 0,
-    limit: int = Query(default=100, lte=100),
+    limit: int = Query(default=100, le=100),
 ):
     heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
     return heroes
index 3c15efbb2d3bffa65cba3a817890ab4222dd2ab9..3069fc5e87a81ee6e3f2e37b371d9ec66a361cc1 100644 (file)
@@ -58,7 +58,7 @@ def create_hero(hero: HeroCreate):
 
 
 @app.get("/heroes/", response_model=List[HeroRead])
-def read_heroes(offset: int = 0, limit: int = Query(default=100, lte=100)):
+def read_heroes(offset: int = 0, limit: int = Query(default=100, le=100)):
     with Session(engine) as session:
         heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
         return heroes
index aef21332a720c322fe106bc0d988c215e804ff79..2b8739ca70ef5f96ffc00a037aecfaf9481117c9 100644 (file)
@@ -52,7 +52,7 @@ def create_hero(hero: HeroCreate):
 
 
 @app.get("/heroes/", response_model=List[HeroRead])
-def read_heroes(offset: int = 0, limit: int = Query(default=100, lte=100)):
+def read_heroes(offset: int = 0, limit: int = Query(default=100, le=100)):
     with Session(engine) as session:
         heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
         return heroes
index 6a0384668683941c62325d585dfb64a7b9c27857..8477e4a2a03832427ff237aa60d20db081a5fdd0 100644 (file)
@@ -104,7 +104,7 @@ def read_heroes(
     *,
     session: Session = Depends(get_session),
     offset: int = 0,
-    limit: int = Query(default=100, lte=100),
+    limit: int = Query(default=100, le=100),
 ):
     heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
     return heroes
@@ -158,7 +158,7 @@ def read_teams(
     *,
     session: Session = Depends(get_session),
     offset: int = 0,
-    limit: int = Query(default=100, lte=100),
+    limit: int = Query(default=100, le=100),
 ):
     teams = session.exec(select(Team).offset(offset).limit(limit)).all()
     return teams
index d106c4ebab63e2ce65f89ab4f4657096eb36f110..3f0602e4b4f9b32aeeafebd20c137ffb78fb003a 100644 (file)
@@ -66,7 +66,7 @@ def read_heroes(
     *,
     session: Session = Depends(get_session),
     offset: int = 0,
-    limit: int = Query(default=100, lte=100),
+    limit: int = Query(default=100, le=100),
 ):
     heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
     return heroes
index 6f84182bc999e9835d21e52d1c495791abff84d3..1da0dad8a26b3fd5a8413016a2ff4dc2b366f9a4 100644 (file)
@@ -95,7 +95,7 @@ def read_heroes(
     *,
     session: Session = Depends(get_session),
     offset: int = 0,
-    limit: int = Query(default=100, lte=100),
+    limit: int = Query(default=100, le=100),
 ):
     heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
     return heroes
@@ -149,7 +149,7 @@ def read_teams(
     *,
     session: Session = Depends(get_session),
     offset: int = 0,
-    limit: int = Query(default=100, lte=100),
+    limit: int = Query(default=100, le=100),
 ):
     teams = session.exec(select(Team).offset(offset).limit(limit)).all()
     return teams
index 35554878db3e96d45960c823a79a991ff88c6a1d..bb98efd58148110e5776f9aef270bbbd793920ba 100644 (file)
@@ -58,7 +58,7 @@ def create_hero(hero: HeroCreate):
 
 
 @app.get("/heroes/", response_model=List[HeroRead])
-def read_heroes(offset: int = 0, limit: int = Query(default=100, lte=100)):
+def read_heroes(offset: int = 0, limit: int = Query(default=100, le=100)):
     with Session(engine) as session:
         heroes = session.exec(select(Hero).offset(offset).limit(limit)).all()
         return heroes
index 8979245dd67858c9512042186ba709d6d010aeee..b08affb92095863c660b83cfe0236f0951011e9d 100644 (file)
@@ -57,9 +57,8 @@ def test_tutorial(clear_sqlmodel):
         assert response.status_code == 404, response.text
 
         response = client.get("/openapi.json")
-        data = response.json()
         assert response.status_code == 200, response.text
-        assert data == {
+        assert response.json() == {
             "openapi": "3.0.2",
             "info": {"title": "FastAPI", "version": "0.1.0"},
             "paths": {
@@ -82,9 +81,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
index d7f642a788ea9c9e33fbccc23e34f40a0331fcde..0aee3ca004463f0592e75a8af01c1292843085dc 100644 (file)
@@ -62,9 +62,8 @@ def test_tutorial(clear_sqlmodel):
         assert data[0]["name"] == hero2_data["name"]
 
         response = client.get("/openapi.json")
-        data = response.json()
         assert response.status_code == 200, response.text
-        assert data == {
+        assert response.json() == {
             "openapi": "3.0.2",
             "info": {"title": "FastAPI", "version": "0.1.0"},
             "paths": {
@@ -87,9 +86,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
index 2ea5e8d6443ec278228553bdf1386dbc1d98540c..8869862e95baa804bea49698eb351e6a779c66b2 100644 (file)
@@ -105,9 +105,8 @@ def test_tutorial(clear_sqlmodel):
         assert len(data) == 1
 
         response = client.get("/openapi.json")
-        data = response.json()
         assert response.status_code == 200, response.text
-        assert data == {
+        assert response.json() == {
             "openapi": "3.0.2",
             "info": {"title": "FastAPI", "version": "0.1.0"},
             "paths": {
@@ -130,9 +129,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
@@ -329,9 +328,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
index da87b8e5c03d59b15eda1adace0c60b5f40cf33d..cb0a6f9282a3b6aa28b3779da1f75b8d4fec650e 100644 (file)
@@ -57,9 +57,8 @@ def test_tutorial(clear_sqlmodel):
         assert response.status_code == 404, response.text
 
         response = client.get("/openapi.json")
-        data = response.json()
         assert response.status_code == 200, response.text
-        assert data == {
+        assert response.json() == {
             "openapi": "3.0.2",
             "info": {"title": "FastAPI", "version": "0.1.0"},
             "paths": {
@@ -82,9 +81,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
index 08be835a171d5aa4b0fcdd80e6eebd1c929441fe..e66c975142f3b464ba5013480e8895e7e60da274 100644 (file)
@@ -92,9 +92,8 @@ def test_tutorial(clear_sqlmodel):
         assert len(data) == 1
 
         response = client.get("/openapi.json")
-        data = response.json()
         assert response.status_code == 200, response.text
-        assert data == {
+        assert response.json() == {
             "openapi": "3.0.2",
             "info": {"title": "FastAPI", "version": "0.1.0"},
             "paths": {
@@ -117,9 +116,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
@@ -316,9 +315,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",
index 7f48780109cd4ecefa0ccffd3639280c81eb2221..49906256c9cfd50e1eb7e9b680f402bfc5440d56 100644 (file)
@@ -64,9 +64,8 @@ def test_tutorial(clear_sqlmodel):
         assert response.status_code == 404, response.text
 
         response = client.get("/openapi.json")
-        data = response.json()
         assert response.status_code == 200, response.text
-        assert data == {
+        assert response.json() == {
             "openapi": "3.0.2",
             "info": {"title": "FastAPI", "version": "0.1.0"},
             "paths": {
@@ -89,9 +88,9 @@ def test_tutorial(clear_sqlmodel):
                                 "required": False,
                                 "schema": {
                                     "title": "Limit",
+                                    "maximum": 100.0,
                                     "type": "integer",
                                     "default": 100,
-                                    "lte": 100,
                                 },
                                 "name": "limit",
                                 "in": "query",