cdr.c: Replace redundant check with an ast_assert()

The only caller of cdr_object_fn_table.process_party_b() explicitly does
the check before calling.

Change-Id: Ib0c53cdf5048227842846e0df9d2c19117c45618

diff --git a/main/cdr.c b/main/cdr.c
index 4bcfc05b39874e4b39d8d645f91aa01a9a517a9c..f313f0b6332b49c4b3be9db9f234a336ccefea6f 100644 (file)
--- a/main/cdr.c
+++ b/main/cdr.c
@@ -1626,11 +1626,9 @@ static int single_state_process_parking_bridge_enter(struct cdr_object *cdr, str
 static void dial_state_process_party_b(struct cdr_object *cdr, struct ast_channel_snapshot *snapshot)
 {
        ast_assert(snapshot != NULL);
+       ast_assert(cdr->party_b.snapshot
+               && !strcasecmp(cdr->party_b.snapshot->name, snapshot->name));
 
-       if (!cdr->party_b.snapshot
-               || strcasecmp(cdr->party_b.snapshot->name, snapshot->name)) {
-               return;
-       }
        cdr_object_swap_snapshot(&cdr->party_b, snapshot);
 
        /* If party B hangs up, finalize this CDR */
@@ -1826,10 +1824,9 @@ static int dialed_pending_state_process_dial_begin(struct cdr_object *cdr, struc
 
 static void bridge_state_process_party_b(struct cdr_object *cdr, struct ast_channel_snapshot *snapshot)
 {
-       if (!cdr->party_b.snapshot
-               || strcasecmp(cdr->party_b.snapshot->name, snapshot->name)) {
-               return;
-       }
+       ast_assert(cdr->party_b.snapshot
+               && !strcasecmp(cdr->party_b.snapshot->name, snapshot->name));
+
        cdr_object_swap_snapshot(&cdr->party_b, snapshot);
 
        /* If party B hangs up, finalize this CDR */