]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
leds: tca6507: Use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 23 Apr 2025 07:53:53 +0000 (09:53 +0200)
committerLee Jones <lee@kernel.org>
Wed, 14 May 2025 08:25:01 +0000 (09:25 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250423-gpiochip-set-rv-leds-v1-4-2f42d8fbb525@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-tca6507.c

index acbd8169723c07331a89ff491ad9ead1ea83f5aa..89c165c8ee9c6eed145cd845565fdb585ca6334e 100644 (file)
@@ -588,8 +588,8 @@ static int tca6507_blink_set(struct led_classdev *led_cdev,
 }
 
 #ifdef CONFIG_GPIOLIB
-static void tca6507_gpio_set_value(struct gpio_chip *gc,
-                                  unsigned offset, int val)
+static int tca6507_gpio_set_value(struct gpio_chip *gc, unsigned int offset,
+                                 int val)
 {
        struct tca6507_chip *tca = gpiochip_get_data(gc);
        unsigned long flags;
@@ -604,13 +604,14 @@ static void tca6507_gpio_set_value(struct gpio_chip *gc,
        spin_unlock_irqrestore(&tca->lock, flags);
        if (tca->reg_set)
                schedule_work(&tca->work);
+
+       return 0;
 }
 
 static int tca6507_gpio_direction_output(struct gpio_chip *gc,
                                          unsigned offset, int val)
 {
-       tca6507_gpio_set_value(gc, offset, val);
-       return 0;
+       return tca6507_gpio_set_value(gc, offset, val);
 }
 
 static int tca6507_probe_gpios(struct device *dev,
@@ -636,7 +637,7 @@ static int tca6507_probe_gpios(struct device *dev,
        tca->gpio.base = -1;
        tca->gpio.owner = THIS_MODULE;
        tca->gpio.direction_output = tca6507_gpio_direction_output;
-       tca->gpio.set = tca6507_gpio_set_value;
+       tca->gpio.set_rv = tca6507_gpio_set_value;
        tca->gpio.parent = dev;
        err = devm_gpiochip_add_data(dev, &tca->gpio, tca);
        if (err) {