]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/sched: Warn if pending_list is not empty
authorPhilipp Stanner <phasta@kernel.org>
Thu, 10 Jul 2025 12:54:09 +0000 (14:54 +0200)
committerPhilipp Stanner <phasta@kernel.org>
Thu, 10 Jul 2025 15:07:08 +0000 (17:07 +0200)
drm_sched_fini() can leak jobs under certain circumstances.

Warn if that happens.

Acked-by: Danilo Krummrich <dakr@kernel.org>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250710125412.128476-7-phasta@kernel.org
drivers/gpu/drm/scheduler/sched_main.c

index a971f0c9e6e08af05f7cc27aee749cd746bd3cd0..d94270cf8bf5c8d7b8ddb17db12118a4c55ca43c 100644 (file)
@@ -1414,6 +1414,9 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched)
        sched->ready = false;
        kfree(sched->sched_rq);
        sched->sched_rq = NULL;
+
+       if (!list_empty(&sched->pending_list))
+               dev_warn(sched->dev, "Tearing down scheduler while jobs are pending!\n");
 }
 EXPORT_SYMBOL(drm_sched_fini);