]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sound: ua101: fix division by zero at probe
authorSeungJu Cheon <suunj1331@gmail.com>
Sun, 26 Apr 2026 11:12:39 +0000 (20:12 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 27 Apr 2026 12:24:41 +0000 (14:24 +0200)
Add a missing sanity check for bNrChannels in detect_usb_format()
to prevent a division by zero in playback_urb_complete() and
capture_urb_complete().

USB core does not validate class-specific descriptor fields such
as bNrChannels, so drivers must verify them before use. If a
device provides bNrChannels = 0, frame_bytes becomes zero and is
later used as a divisor in the URB completion handlers, leading
to a kernel crash.

Fixes: 63978ab3e3e9 ("sound: add Edirol UA-101 support")
Cc: stable@vger.kernel.org
Signed-off-by: SeungJu Cheon <suunj1331@gmail.com>
Link: https://patch.msgid.link/20260426111239.103296-1-suunj1331@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/misc/ua101.c

index 49b3dd8d827dae87b91ac7ae97ad136b1d155ff2..d129b42eb979d05c88d6eb0f4f169e3e9e136175 100644 (file)
@@ -974,6 +974,13 @@ static int detect_usb_format(struct ua101 *ua)
 
        ua->capture.channels = fmt_capture->bNrChannels;
        ua->playback.channels = fmt_playback->bNrChannels;
+       if (!ua->capture.channels || !ua->playback.channels) {
+               dev_err(&ua->dev->dev,
+                       "invalid channel count: capture %u, playback %u\n",
+                       ua->capture.channels, ua->playback.channels);
+               return -EINVAL;
+       }
+
        ua->capture.frame_bytes =
                fmt_capture->bSubframeSize * ua->capture.channels;
        ua->playback.frame_bytes =