perf: add page_faults_min software perf event support

This patch adds support and documentation
for the page_faults_min perf event.

Signed-off-by: Nitesh Konkar <nitkon12@linux.vnet.ibm.com>

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index d407a786c499cedf559f3e3d82712fae98c4a8a8..4ee3464d62a64d67020bc15c0b3c4bc43a5c9eaa 100644 (file)
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1952,6 +1952,7 @@
   <event name='page_faults' enabled='no'/>
   <event name='context_switches' enabled='no'/>
   <event name='cpu_migrations' enabled='no'/>
+  <event name='page_faults_min' enabled='no'/>
 </perf>
 ...
 </pre>
@@ -2064,6 +2065,14 @@
           applications running on the platform</td>
       <td><code>perf.cpu_migrations</code></td>
     </tr>
+    <tr>
+      <td><code>page_faults_min</code></td>
+      <td>the count of minor page faults, that is, where the
+          page was present in the page cache, and therefore
+          the fault avoided loading it from storage, by
+          applications running on the platform</td>
+      <td><code>perf.page_faults_min</code></td>
+    </tr>
   </table>
 
     <h3><a name="elementsDevices">Devices</a></h3>

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index a14b18a68114f4069f9217f2656bc222ea39c2f3..b8914d5f4d8be5684f409b21935cc6227cf7d24f 100644 (file)
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -438,6 +438,7 @@
               <value>page_faults</value>
               <value>context_switches</value>
               <value>cpu_migrations</value>
+              <value>page_faults_min</value>
             </choice>
           </attribute>
           <attribute name="enabled">

diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index 7e24f5063593fdbfd97e5354ac765b6d854bcc32..b7e6c712e2eea9ccec867a1aeaf3e92730253fde 100644 (file)
--- a/include/libvirt/libvirt-domain.h
+++ b/include/libvirt/libvirt-domain.h
@@ -2240,6 +2240,16 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats);
  */
 # define VIR_PERF_PARAM_CPU_MIGRATIONS "cpu_migrations"
 
+/**
+ * VIR_PERF_PARAM_PAGE_FAULTS_MIN:
+ *
+ * Macro for typed parameter name that represents page_faults_min
+ * perf event which can be used to measure the count of minor page
+ * faults by applications running on the platform. It corresponds
+ * to the "perf.page_faults_min" field in the *Stats APIs.
+ */
+# define VIR_PERF_PARAM_PAGE_FAULTS_MIN  "page_faults_min"
+
 int virDomainGetPerfEvents(virDomainPtr dom,
                            virTypedParameterPtr *params,
                            int *nparams,

diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 05b09f94edcf1540e771981efda15994639cbfd1..f0e4f8fe37b42fa0fcbd77fd8e0839cecbf35619 100644 (file)
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -11263,6 +11263,9 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
  *                             processor to another, as unsigned long
  *                             long. It is produced by the cpu_migrations
  *                             perf event.
+ *     "perf.page_faults_min" - The count of minor page faults as unsigned
+ *                              long long. It is produced by the
+ *                              page_faults_min perf event.
  *
  * Note that entire stats groups or individual stat fields may be missing from
  * the output in case they are not supported by the given hypervisor, are not

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 88116cf7dab66bef984bb5e4716307e6e77fa0da..02bd7caa3bc2d0e67484a11c76cb39651b8394c6 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -9572,6 +9572,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom,
                                VIR_PERF_PARAM_PAGE_FAULTS, VIR_TYPED_PARAM_BOOLEAN,
                                VIR_PERF_PARAM_CONTEXT_SWITCHES, VIR_TYPED_PARAM_BOOLEAN,
                                VIR_PERF_PARAM_CPU_MIGRATIONS, VIR_TYPED_PARAM_BOOLEAN,
+                               VIR_PERF_PARAM_PAGE_FAULTS_MIN, VIR_TYPED_PARAM_BOOLEAN,
                                NULL) < 0)
         return -1;
 

diff --git a/src/util/virperf.c b/src/util/virperf.c
index 0127c828af26c0d404289b277abcf71e914ea247..9e41df9c5172ddac4f486813c837a118910abb07 100644 (file)
--- a/src/util/virperf.c
+++ b/src/util/virperf.c
@@ -45,7 +45,8 @@ VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST,
               "bus_cycles", "stalled_cycles_frontend",
               "stalled_cycles_backend", "ref_cpu_cycles",
               "cpu_clock", "task_clock", "page_faults",
-              "context_switches", "cpu_migrations");
+              "context_switches", "cpu_migrations",
+              "page_faults_min");
 
 struct virPerfEvent {
     int type;
@@ -129,6 +130,9 @@ static struct virPerfEventAttr attrs[] = {
     {.type = VIR_PERF_EVENT_CPU_MIGRATIONS,
      .attrType = PERF_TYPE_SOFTWARE,
      .attrConfig = PERF_COUNT_SW_CPU_MIGRATIONS},
+    {.type = VIR_PERF_EVENT_PAGE_FAULTS_MIN,
+     .attrType = PERF_TYPE_SOFTWARE,
+     .attrConfig = PERF_COUNT_SW_PAGE_FAULTS_MIN},
 };
 typedef struct virPerfEventAttr *virPerfEventAttrPtr;
 

diff --git a/src/util/virperf.h b/src/util/virperf.h
index 90ae007295558f6de2346f345de5f181eb06557c..aa90273a22391e29b264a4f420a9273466ff36ae 100644 (file)
--- a/src/util/virperf.h
+++ b/src/util/virperf.h
@@ -52,6 +52,7 @@ typedef enum {
     VIR_PERF_EVENT_PAGE_FAULTS,   /* Count of total page faults */
     VIR_PERF_EVENT_CONTEXT_SWITCHES,   /* Count of context switches */
     VIR_PERF_EVENT_CPU_MIGRATIONS,   /* Count of cpu migrations */
+    VIR_PERF_EVENT_PAGE_FAULTS_MIN,   /* Count of minor page faults */
 
     VIR_PERF_EVENT_LAST
 } virPerfEventType;

diff --git a/tests/genericxml2xmlindata/generic-perf.xml b/tests/genericxml2xmlindata/generic-perf.xml
index f8563189fa45565b09e397bd1c594522f879f7bf..62ad97316890e2223bb875b32c1b7400941334f5 100644 (file)
--- a/tests/genericxml2xmlindata/generic-perf.xml
+++ b/tests/genericxml2xmlindata/generic-perf.xml
@@ -31,6 +31,7 @@
     <event name='page_faults' enabled='yes'/>
     <event name='context_switches' enabled='yes'/>
     <event name='cpu_migrations' enabled='yes'/>
+    <event name='page_faults_min' enabled='yes'/>
   </perf>
   <devices>
   </devices>

diff --git a/tools/virsh.pod b/tools/virsh.pod
index 6ae21590dd0437db7555993a24bc4158dc26da70..5c0876b1b29c67b3b64af1b39a2c854f8f7f4aef 100644 (file)
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -969,6 +969,7 @@ I<--perf> returns the statistics of all enabled perf events:
  "perf.page_faults" - the count of page faults
  "perf.context_switches" - the count of context switches
  "perf.cpu_migrations" - the count of cpu migrations
+ "perf.page_faults_min" - the count of minor page faults
 
 See the B<perf> command for more details about each event.
 
@@ -2348,6 +2349,8 @@ B<Valid perf event names>
                      by applications running on the platform.
   cpu_migrations - Provides the count cpu migrations by
                    applications running on the platform.
+  page_faults_min - Provides the count minor page faults
+                    by applications running on the platform.
 
 B<Note>: The statistics can be retrieved using the B<domstats> command using
 the I<--perf> flag.