final cleanup:
=============
-- review code for:
+- rereview code
- string safety, particularly strcmp use -- little is guaranteed to be a string,
- do not use string functions without extreme caution.
+ do not use string functions without extreme caution. (done)
- memory leaks (first pass done, vg runs clean)
- - other memory management issues
-- scan for leftover bogosities with "XXX" tag (in new code only!)
-- review code format
+ - other memory management issues (open-ended, but looking)
+- review code format (whitespace checked)
+ -- nuke icky // comments (and probably attatched code)
- catalog namespace changes for review
integration issues:
==================
- review namespace use
- decide whether to up MAXHOPS
+- merge with current trunk
testing issues/open questions:
=============================
krb5_boolean krb5_is_referral_realm(krb5_data *r)
{
- /*
- * Check for a match with KRB5_REFERRAL_REALM. Currently this relies
- * on that string constant being zero-length. (Unlike principal realm
- * names, KRB5_REFERRAL_REALM is known to be a string.)
- */
+ /*
+ * Check for a match with KRB5_REFERRAL_REALM. Currently this relies
+ * on that string constant being zero-length. (Unlike principal realm
+ * names, KRB5_REFERRAL_REALM is known to be a string.)
+ */
#ifdef DEBUG_REFERRALS
#if 0
printf("krb5_is_ref_realm: checking <%s> for referralness: %s\n",
free(enctypes);
if (retval) {
#ifdef DEBUG_REFERRALS
- printf("krb5_get_cred_via_tkt ending early after send_tgs with: %s\n",
- error_message(retval));
+ printf("krb5_get_cred_via_tkt ending early after send_tgs with: %s\n",
+ error_message(retval));
#endif
return retval;
}