use CMP() CID #1503972

diff --git a/src/listen/radius/proto_radius_udp.c b/src/listen/radius/proto_radius_udp.c
index 0169d414025ed1932ed5d39d9391406757641295..78541c14545ad098f556857513e4ed5217be2bc0 100644 (file)
--- a/src/listen/radius/proto_radius_udp.c
+++ b/src/listen/radius/proto_radius_udp.c
@@ -395,7 +395,7 @@ static int8_t session_cmp(void const *one, void const *two)
 {
        proto_radius_udp_state_t const *a = (proto_radius_udp_state_t const *) one;
        proto_radius_udp_state_t const *b = (proto_radius_udp_state_t const *) two;
-       int rcode;
+       uint8_t rcode;
 
        fr_assert(a->state != NULL);
        fr_assert(b->state != NULL);
@@ -403,7 +403,7 @@ static int8_t session_cmp(void const *one, void const *two)
        rcode = CMP(a->len, b->len);
        if (!rcode) return rcode;
 
-       return memcmp(a->state, b->state, a->len);
+       return CMP(memcmp(a->state, b->state, a->len), 0);
 }