wrapper: fix segfault in cgroup_get_value_uint64()

The second and third arguments passed to cgroup_get_value_uint64() are
of type char * and the user might pass NULL in place of one or both of
the arguments, causing a segfault. The reason is, argument values are
used without checks, fix it by checking for NULL pointers before
proceeding.

Reproducer:
-----------
 #include <stdlib.h>
 #include <libcgroup.h>

 int main(void)
 {
 	struct cgroup_controller *cgc;
 	struct cgroup *cgrp;
 	int ret;

 	ret = cgroup_init();
 	if (ret)
 		exit(1);

 	cgrp = cgroup_new_cgroup("fuzzer");
 	if (!cgrp)
 		exit(1);

 	cgc = cgroup_add_controller(cgrp, "cpu");
 	if (!cgc)
 		exit(1);

 	ret = cgroup_add_value_string(cgc, "cpu.shares", "512");
 	if (ret)
 		exit (1);

 	cgroup_get_value_uint64(cgc, NULL, NULL);
 	// should not reach here.
 	return 0;
 }

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
(cherry picked from commit 5ac8e5e4cfca037198b729435bdeb692ec90d351)

diff --git a/src/wrapper.c b/src/wrapper.c
index a8b9a54f39624b656a6696f46767a198c92b5c4c..7ccad67634e93987f034676bc05c4be8a6ea93e5 100644 (file)
--- a/src/wrapper.c
+++ b/src/wrapper.c
@@ -529,7 +529,7 @@ int cgroup_get_value_uint64(struct cgroup_controller *controller, const char *na
 {
        int i;
 
-       if (!controller)
+       if (!controller || !name || !value)
                return ECGINVAL;
 
        for (i = 0; i < controller->index; i++) {