]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: chemical: sunrise_co2: use = { } instead of memset()
authorDavid Lechner <dlechner@baylibre.com>
Wed, 11 Jun 2025 22:39:06 +0000 (17:39 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 26 Jun 2025 18:32:56 +0000 (19:32 +0100)
Use { } instead of memset() to zero-initialize stack memory to simplify
the code.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250611-iio-zero-init-stack-with-instead-of-memset-v1-14-ebb2d0a24302@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/sunrise_co2.c

index af79efde37e89170128ef9351bf1ad8b993d4a2d..158be9d798d26199cfb40ef0d294f967ba8a737f 100644 (file)
@@ -51,13 +51,12 @@ static int sunrise_regmap_read(void *context, const void *reg_buf,
 {
        struct i2c_client *client = context;
        struct sunrise_dev *sunrise = i2c_get_clientdata(client);
-       union i2c_smbus_data data;
+       union i2c_smbus_data data = { };
        int ret;
 
        if (reg_size != 1 || !val_size)
                return -EINVAL;
 
-       memset(&data, 0, sizeof(data));
        data.block[0] = val_size;
 
        /*
@@ -88,14 +87,13 @@ static int sunrise_regmap_write(void *context, const void *val_buf, size_t count
 {
        struct i2c_client *client = context;
        struct sunrise_dev *sunrise = i2c_get_clientdata(client);
-       union i2c_smbus_data data;
+       union i2c_smbus_data data = { };
 
        /* Discard reg address from values count. */
        if (!count)
                return -EINVAL;
        count--;
 
-       memset(&data, 0, sizeof(data));
        data.block[0] = count;
        memcpy(&data.block[1], (u8 *)val_buf + 1, count);