ALSA: hda: Fix headset detection failure due to unstable sort

commit 3b4309546b48fc167aa615a2d881a09c0a97971f upstream.

The auto_parser assumed sort() was stable, but the kernel's sort() uses
heapsort, which has never been stable. After commit 0e02ca29a563
("lib/sort: optimize heapsort with double-pop variation"), the order of
equal elements changed, causing the headset to fail to work.

Fix the issue by recording the original order of elements before
sorting and using it as a tiebreaker for equal elements in the
comparison function.

Fixes: b9030a005d58 ("ALSA: hda - Use standard sort function in hda_auto_parser.c")
Reported-by: Austrum <austrum.lab@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219158
Tested-by: Austrum <austrum.lab@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Link: https://patch.msgid.link/20250128165415.643223-1-visitorckw@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c
index 7c6b1fe8dfcce390251196d9fe545e9ca2a59b52..58b2e25c448e551dd3717ce26a89cd8d7dcbf7f7 100644 (file)
--- a/sound/pci/hda/hda_auto_parser.c
+++ b/sound/pci/hda/hda_auto_parser.c
@@ -80,7 +80,11 @@ static int compare_input_type(const void *ap, const void *bp)
 
        /* In case one has boost and the other one has not,
           pick the one with boost first. */
-       return (int)(b->has_boost_on_pin - a->has_boost_on_pin);
+       if (a->has_boost_on_pin != b->has_boost_on_pin)
+               return (int)(b->has_boost_on_pin - a->has_boost_on_pin);
+
+       /* Keep the original order */
+       return a->order - b->order;
 }
 
 /* Reorder the surround channels
@@ -400,6 +404,8 @@ int snd_hda_parse_pin_defcfg(struct hda_codec *codec,
        reorder_outputs(cfg->speaker_outs, cfg->speaker_pins);
 
        /* sort inputs in the order of AUTO_PIN_* type */
+       for (i = 0; i < cfg->num_inputs; i++)
+               cfg->inputs[i].order = i;
        sort(cfg->inputs, cfg->num_inputs, sizeof(cfg->inputs[0]),
             compare_input_type, NULL);
 

diff --git a/sound/pci/hda/hda_auto_parser.h b/sound/pci/hda/hda_auto_parser.h
index df63d66af1ab1e303e4730f738d025e22ba40f4b..8bb8202cf2842311ddfe79ca71ad0622c2fb801b 100644 (file)
--- a/sound/pci/hda/hda_auto_parser.h
+++ b/sound/pci/hda/hda_auto_parser.h
@@ -35,6 +35,7 @@ struct auto_pin_cfg_item {
        unsigned int is_headset_mic:1;
        unsigned int is_headphone_mic:1; /* Mic-only in headphone jack */
        unsigned int has_boost_on_pin:1;
+       int order;
 };
 
 struct auto_pin_cfg;