]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Add comment what the effect of calling the qname-minimization
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 10 Aug 2020 11:36:15 +0000 (13:36 +0200)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Wed, 26 Aug 2020 11:01:18 +0000 (13:01 +0200)
fallback code can be for maxdepth.

(cherry picked from commit a4980f5632404f84b7de976595d43b4969b7feac)

pdns/syncres.cc

index 97a813ece76909de0a6a9ea12404cb41e556150c..24b0a8f5054f7723b2d4aff1664051e2ffcf3c45 100644 (file)
@@ -739,6 +739,9 @@ int SyncRes::doResolve(const DNSName &qname, const QType &qtype, vector<DNSRecor
         // Case 5: unexpected answer
         QLOG("Step5: other rcode, last effort final resolve");
         setQNameMinimization(false);
+        // We might have hit a depth level check, but we still want to allow some recursion levels in the fallback
+        // no-qname-minimization case. This has the effect that a qname minimization fallback case might reach 150% of
+        // maxdepth.
         res = doResolveNoQNameMinimization(qname, qtype, ret, depth/2, beenthere, state);
 
         if(res == RCode::NoError) {