UINT8_MAX is 255. Characters go from 0..255. Which is 256

diff --git a/src/lib/util/base16.c b/src/lib/util/base16.c
index 441e31b8bbf4442085763029924bae9ef6e31c59..98793ff4bc19bf7d7390a104268528a8b07d2a0d 100644 (file)
--- a/src/lib/util/base16.c
+++ b/src/lib/util/base16.c
@@ -28,7 +28,7 @@ RCSID("$Id$")
 /** lower case encode alphabet for base16
  *
  */
-char const fr_base16_alphabet_encode_lc[UINT8_MAX] = {
+char const fr_base16_alphabet_encode_lc[UINT8_MAX + 1] = {
        [0] = '0',
        [1] = '1',
        [2] = '2',
@@ -50,7 +50,7 @@ char const fr_base16_alphabet_encode_lc[UINT8_MAX] = {
 /** lower case encode alphabet for base16
  *
  */
-char const fr_base16_alphabet_encode_uc[UINT8_MAX] = {
+char const fr_base16_alphabet_encode_uc[UINT8_MAX + 1] = {
        [0] = '0',
        [1] = '1',
        [2] = '2',
@@ -72,7 +72,7 @@ char const fr_base16_alphabet_encode_uc[UINT8_MAX] = {
 /** Mixed case decode alphabet for base16
  *
  */
-uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX] = {
+uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX + 1] = {
        F32(0, UINT8_MAX), F16(32, UINT8_MAX),
        ['0'] = 0,
        ['1'] = 1,

diff --git a/src/lib/util/base16.h b/src/lib/util/base16.h
index 7962ad2e09c9f6f1eb73d17d5f4dd2e45d5147f1..3623ccb4832c145cd63be46f4e0e5a66a17284a4 100644 (file)
--- a/src/lib/util/base16.h
+++ b/src/lib/util/base16.h
@@ -36,9 +36,9 @@ extern "C" {
 #include <stdint.h>
 #include <sys/types.h>
 
-extern char const fr_base16_alphabet_encode_lc[UINT8_MAX];
-extern char const fr_base16_alphabet_encode_uc[UINT8_MAX];
-extern uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX];  /* mixed case */
+extern char const fr_base16_alphabet_encode_lc[UINT8_MAX + 1];
+extern char const fr_base16_alphabet_encode_uc[UINT8_MAX + 1];
+extern uint8_t const fr_base16_alphabet_decode_mc[UINT8_MAX + 1];      /* mixed case */
 
 /** Check if char is in base16 alphabet
  *