Do not trigger bwrap's max arg limit when running modinfo

We might potentially pass a lot of modules at once to modinfo which
could trigger bwrap's max argument limit so make sure to chunk things
up to avoid hitting the limit.

diff --git a/mkosi/kmod.py b/mkosi/kmod.py
index 4010d62b3fc7706d2c822422500580ffcedc198a..1799f4f9a5ee845e6d9bf39d4d5814a3e0161cbb 100644 (file)
--- a/mkosi/kmod.py
+++ b/mkosi/kmod.py
@@ -58,8 +58,13 @@ def resolve_module_dependencies(root: Path, kver: str, modules: Sequence[str]) -
     # We could run modinfo once for each module but that's slow. Luckily we can pass multiple modules to
     # modinfo and it'll process them all in a single go. We get the modinfo for all modules to build two maps
     # that map the path of the module to its module dependencies and its firmware dependencies respectively.
-    info = bwrap(chroot_cmd(root) + ["modinfo", "--set-version", kver, "--null", *nametofile.keys()],
-                 stdout=subprocess.PIPE).stdout
+    # Because there's more kernel modules than the max number of accepted CLI arguments for bwrap, we split the modules
+    # list up into chunks.
+    info = ""
+    for i in range(0, len(nametofile.keys()), 8500):
+        chunk = list(nametofile.keys())[i:i+8500]
+        info += bwrap(chroot_cmd(root) + ["modinfo", "--set-version", kver, "--null", *chunk],
+                      stdout=subprocess.PIPE).stdout.strip()
 
     log_step("Calculating required kernel modules and firmware")