]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: freescale: ucc_geth: call of_node_put once
authorRosen Penev <rosenp@gmail.com>
Tue, 24 Feb 2026 01:41:41 +0000 (17:41 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 25 Feb 2026 02:26:30 +0000 (18:26 -0800)
Move it up to avoid placing it in both the error and success paths.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260224014141.352642-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/ucc_geth.c

index 131d1210dc4a84d9fdfc320a7a596d97c616f02b..a4eb71dcd6c53a83b17e5c88c9f5fb05646f8e63 100644 (file)
@@ -3470,14 +3470,13 @@ static int ucc_geth_probe(struct platform_device* ofdev)
        phy_node = of_parse_phandle(np, "phy-handle", 0);
        if (phy_node) {
                prop = of_get_property(phy_node, "interface", NULL);
+               of_node_put(phy_node);
                if (prop) {
                        dev_err(&ofdev->dev,
                                "Device-tree property 'interface' is no longer supported. Please use 'phy-connection-type' instead.");
-                       of_node_put(phy_node);
                        err = -EINVAL;
                        goto err_put_tbi;
                }
-               of_node_put(phy_node);
        }
 
        err = of_get_phy_mode(np, &phy_interface);