]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: musb: dma: Correct parameter passed to IRQ handler
authorPaul Cercueil <paul@crapouillou.net>
Mon, 16 Dec 2019 16:18:43 +0000 (10:18 -0600)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 28 Apr 2020 18:03:12 +0000 (19:03 +0100)
commit c80d0f4426c7fdc7efd6ae8d8b021dcfc89b4254 upstream.

The IRQ handler was passed a pointer to a struct dma_controller, but the
argument was then casted to a pointer to a struct musb_dma_controller.

Fixes: 427c4f333474 ("usb: struct device - replace bus_id with dev_name(), dev_set_name()")
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: Artur Rojek <contact@artur-rojek.eu>
Signed-off-by: Bin Liu <b-liu@ti.com>
Link: https://lore.kernel.org/r/20191216161844.772-2-b-liu@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/usb/musb/musbhsdma.c

index d006f54d5e158929c6d35b470f52f9da3c2e8ad4..5edca85a491a500d981f5eb250a28d3103c58ad8 100644 (file)
@@ -396,7 +396,7 @@ struct dma_controller *dma_controller_create(struct musb *musb, void __iomem *ba
        controller->controller.channel_abort = dma_channel_abort;
 
        if (request_irq(irq, dma_controller_irq, 0,
-                       dev_name(musb->controller), &controller->controller)) {
+                       dev_name(musb->controller), controller)) {
                dev_err(dev, "request_irq %d failed!\n", irq);
                dma_controller_destroy(&controller->controller);