]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpuidle: menu: Drop a redundant local variable
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 6 Feb 2025 14:22:59 +0000 (15:22 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 25 Feb 2025 10:59:02 +0000 (11:59 +0100)
Local variable min in get_typical_interval() is updated, but never
accessed later, so drop it.

No functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Tested-by: Christian Loehle <christian.loehle@arm.com>
Tested-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
Link: https://patch.msgid.link/13699686.uLZWGnKmhe@rjwysocki.net
drivers/cpuidle/governors/menu.c

index 28363bfa3e4c9feb8827d97d407d53ffd6035d1c..b19406502b569ae1ceb68ce08b4241dbda9991f6 100644 (file)
@@ -117,7 +117,7 @@ static void menu_update(struct cpuidle_driver *drv, struct cpuidle_device *dev);
 static unsigned int get_typical_interval(struct menu_device *data)
 {
        int i, divisor;
-       unsigned int min, max, thresh, avg;
+       unsigned int max, thresh, avg;
        uint64_t sum, variance;
 
        thresh = INT_MAX; /* Discard outliers above this value */
@@ -125,7 +125,6 @@ static unsigned int get_typical_interval(struct menu_device *data)
 again:
 
        /* First calculate the average of past intervals */
-       min = UINT_MAX;
        max = 0;
        sum = 0;
        divisor = 0;
@@ -136,9 +135,6 @@ again:
                        divisor++;
                        if (value > max)
                                max = value;
-
-                       if (value < min)
-                               min = value;
                }
        }