Lint fixes (consts, boolean conditions)

diff --git a/pdns/decafsigners.cc b/pdns/decafsigners.cc
index 9f3bd1bda32b8a6c44ce08c53bd0eeaf2da4a5a1..9ebc9d2aea5d0a4268d95061f576b786b568da27 100644 (file)
--- a/pdns/decafsigners.cc
+++ b/pdns/decafsigners.cc
@@ -421,7 +421,7 @@ bool DecafED448DNSCryptoKeyEngine::verify(const std::string& msg, const std::str
 
 namespace
 {
-struct LoaderDecafStruct
+const struct LoaderDecafStruct
 {
   LoaderDecafStruct()
   {

diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index 80a8b89cabf5b24e6673adc604ea2f6fc823155f..43d623f93e18e91ce3d64b4fa2086fe247240eb5 100644 (file)
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -225,7 +225,7 @@ vector<pair<uint8_t, string>> DNSCryptoKeyEngine::listAllAlgosWithBackend()
 void DNSCryptoKeyEngine::report(unsigned int algo, maker_t* maker, bool fallback)
 {
   getAllMakers()[algo].push_back(maker);
-  if (getMakers().count(algo) && fallback) {
+  if (getMakers().count(algo) != 0 && fallback) {
     return;
   }
   getMakers()[algo] = maker;

diff --git a/pdns/opensslsigners.cc b/pdns/opensslsigners.cc
index c521e1558ffff9d380c0e12be142f89d55e2ed73..3b31fa91c960de352eb59182f91e43aea9ced9c5 100644 (file)
--- a/pdns/opensslsigners.cc
+++ b/pdns/opensslsigners.cc
@@ -1174,7 +1174,7 @@ void OpenSSLEDDSADNSCryptoKeyEngine::fromPublicKeyString(const std::string& cont
 #endif // HAVE_LIBCRYPTO_EDDSA
 
 namespace {
-  struct LoaderStruct
+  const struct LoaderStruct
   {
     LoaderStruct()
     {

diff --git a/pdns/sodiumsigners.cc b/pdns/sodiumsigners.cc
index dbec4af75ee3db3c7b5d9babc7c68d98ad44a5ae..a918260e4104ee58eb000115aee9a4a36a24e1dd 100644 (file)
--- a/pdns/sodiumsigners.cc
+++ b/pdns/sodiumsigners.cc
@@ -200,7 +200,7 @@ bool SodiumED25519DNSCryptoKeyEngine::verify(const std::string& msg, const std::
 }
 
 namespace {
-struct LoaderSodiumStruct
+const struct LoaderSodiumStruct
 {
   LoaderSodiumStruct()
   {