]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-common: Align integer type
authorMartin Schwenke <mschwenke@ddn.com>
Sun, 16 Nov 2025 23:20:11 +0000 (10:20 +1100)
committerVolker Lendecke <vl@samba.org>
Mon, 9 Feb 2026 11:17:41 +0000 (11:17 +0000)
[132/416] Compiling ctdb/common/run_event.c
../../common/run_event.c: In function ‘run_event_fail’:
../../common/run_event.c:806:50: warning: comparison of integer expressions of different signedness: ‘id_t’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare]
  806 |         if (script->summary == -ETIMEDOUT && pid != -1) {
      |                                                  ^~

This is actually due to a typo in commit
20e9f203627752c4c1934e4bc0776e26c0dfb00e.  It should always have been
pid_t.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
ctdb/common/run_event.c

index dee46ad2949fd56d6e3f879ab9b6c658c98847e5..4434fc18804621e887fe4ed01ca98d0c4aad4443 100644 (file)
@@ -548,7 +548,7 @@ static struct tevent_req *run_event_run_script(struct tevent_req *req);
 static void run_event_next_script(struct tevent_req *subreq);
 static void run_event_fail(struct tevent_req *req,
                           struct run_event_script *script,
-                          id_t pid);
+                          pid_t pid);
 static void run_event_debug(struct tevent_req *req, pid_t pid);
 static void run_event_debug_done(struct tevent_req *subreq);
 
@@ -791,7 +791,7 @@ static void run_event_next_script(struct tevent_req *subreq)
 
 static void run_event_fail(struct tevent_req *req,
                           struct run_event_script *script,
-                          id_t pid)
+                          pid_t pid)
 {
        struct run_event_state *state = tevent_req_data(
                req, struct run_event_state);