Lint Sass and rename scss-config.yml to have proper name

diff --git a/scss-lint.yml b/.scss-lint.yml
similarity index 100%
rename from scss-lint.yml
rename to .scss-lint.yml

diff --git a/gulp/lint.js b/gulp/lint.js
index 1c792945a963c79522a37e95ad73266139f998ef..a32f869204c83cb36c35fc26be3133571ed4c27d 100644 (file)
--- a/gulp/lint.js
+++ b/gulp/lint.js
@@ -13,15 +13,13 @@ gulp.task('lint', ['lint:sass', 'lint:javascript']);
 
 gulp.task('lint:sass', function() {
   return gulp.src(PATHS)
-    .pipe(scssLint({
-      'config': 'scss-lint.yml'
-    }));
+    .pipe(scssLint());
 });
 
 gulp.task('lint:javascript', function() {
   jshint.lookup = false;
 
   return gulp.src('js/*.js')
-    .pipe(jshint('./config/.jshintConfig'))
+    .pipe(jshint())
     .pipe(jshint.reporter('default'));
 });

diff --git a/scss/components/_button-group.scss b/scss/components/_button-group.scss
index 07706083664e9107e5c0aa68dec5ac10d484d358..0f1b30a88ccbd04039af6b9fedf3b45e7fdb3c69 100644 (file)
--- a/scss/components/_button-group.scss
+++ b/scss/components/_button-group.scss
@@ -74,6 +74,7 @@ $buttongroup-expand-max: 6 !default;
     }
   }
 
+  // scss-lint:disable ZeroUnit
   #{$selector} {
     @if $global-flexbox {
       flex: 1 1 0px;
@@ -83,7 +84,7 @@ $buttongroup-expand-max: 6 !default;
         &:first-child:nth-last-child(#{$i}) {
           &, &:first-child:nth-last-child(#{$i}) ~ #{$selector} {
             display: inline-block;
-            width: calc( #{percentage(1/$i)} - #{$buttongroup-spacing} );
+            width: calc(#{percentage(1/$i)} - #{$buttongroup-spacing});
             margin-right: $buttongroup-spacing;
           }
         }
@@ -120,6 +121,7 @@ $buttongroup-expand-max: 6 !default;
 @mixin button-group-unstack(
   $selector: $buttongroup-child-selector
 ) {
+  // scss-lint:disable ZeroUnit
   #{$selector} {
     @if $global-flexbox {
       flex: 1 1 0px;
@@ -179,6 +181,7 @@ $buttongroup-expand-max: 6 !default;
       }
     }
 
+    // scss-lint:disable MergeableSelector
     &.stacked-for-small.expanded {
       @include breakpoint(small only) {
         display: block;

diff --git a/scss/components/_dropdown-menu.scss b/scss/components/_dropdown-menu.scss
index 5bd8948f27636506979f53a81dc6f68b57d636f7..8bbd9ac7ca51b3629b1a89b2b34238d8cc6f1ac5 100644 (file)
--- a/scss/components/_dropdown-menu.scss
+++ b/scss/components/_dropdown-menu.scss
@@ -36,20 +36,16 @@ $dropdownmenu-border-width: nth($dropdownmenu-border, 1);
     a {
       @include disable-mouse-outline;
     }
-    &:not(.vertical) {
 
-    }
     .no-js & ul {
       display: none;
     }
 
     &:not(.vertical) {
-      .is-dropdown-submenu {
-        &.first-sub {
-          top: 100%;
-          #{$global-left}: 0;
-          #{$global-right}: auto;
-        }
+      .is-dropdown-submenu.first-sub {
+        top: 100%;
+        #{$global-left}: 0;
+        #{$global-right}: auto;
       }
     }
 

diff --git a/scss/components/_media-object.scss b/scss/components/_media-object.scss
index 814863ae1d4702ef507021ee52a1bc75c1c14ce4..211ba6a046713bd197744485fe7f5615d5036c0e 100644 (file)
--- a/scss/components/_media-object.scss
+++ b/scss/components/_media-object.scss
@@ -91,7 +91,10 @@ $mediaobject-image-width-stacked: 100% !default;
     @include media-object-section;
 
     @if $global-flexbox {
-      &.main-section { flex: 1 1 0px; }
+      // scss-lint:disable ZeroUnit
+      &.main-section {
+        flex: 1 1 0px;
+      }
     }
     @else {
       &.middle { vertical-align: middle; }

diff --git a/scss/components/_menu.scss b/scss/components/_menu.scss
index 756baf803549724a796657902545e1e88db7e4b2..4713634a74cb72a9efb758abfa668a87c1bdaf59 100644 (file)
--- a/scss/components/_menu.scss
+++ b/scss/components/_menu.scss
@@ -72,7 +72,10 @@ $menu-icon-spacing: 0.25rem !default;
 /// Expands the items of a Menu, so each item is the same width.
 @mixin menu-expand {
   @if $global-flexbox {
-    > li { flex: 1 1 0px; }
+    // scss-lint:disable ZeroUnit
+    > li {
+      flex: 1 1 0px;
+    }
   }
   @else {
     width: 100%;

diff --git a/scss/components/_reveal.scss b/scss/components/_reveal.scss
index cc220153d37a890dd4bacab3dcb700d2cc323516..253cee9cc446c331464a7dcb22e4565ba1825430 100644 (file)
--- a/scss/components/_reveal.scss
+++ b/scss/components/_reveal.scss
@@ -69,13 +69,12 @@ $reveal-overlay-background: rgba($black, 0.45) !default;
   // margin: $reveal-offset auto 0;
   background-color: $reveal-background;
   border-radius: $reveal-radius;
-  
+
   //chris's additions
   overflow-y: auto;
   max-height: 100vh;
   //
 
-  
   @include breakpoint(medium) {
     min-height: 0;
   }
@@ -127,7 +126,7 @@ $reveal-overlay-background: rgba($black, 0.45) !default;
   body.is-reveal-open {
     overflow: hidden;
   }
-  
+
   /* this little snippet causes the intended scroll blocking on iOS Safari,
      which can still DIAF, because it breaks literally everything else */
   // html.is-reveal-open, body.is-reveal-open {
@@ -147,14 +146,14 @@ $reveal-overlay-background: rgba($black, 0.45) !default;
     @include reveal-modal-width($reveal-width);
     position: absolute;
     overflow-y: auto;
-    
-    
+
+
     // &.is-ios {
     //   :last-child {
     //     padding-bottom: 1em;
     //   }
     // }
-    
+
     /*** chris's addition ***/
     @include breakpoint(small) {
       width: 100vw;

diff --git a/scss/components/_title-bar.scss b/scss/components/_title-bar.scss
index 3ce5fe75555015296c508e095f95493f2b1d17eb..eb194c96299a5ac92729d1bd2f11fb1decedae63 100644 (file)
--- a/scss/components/_title-bar.scss
+++ b/scss/components/_title-bar.scss
@@ -56,6 +56,7 @@ $titlebar-icon-spacing: 0.25rem !default;
   }
 
   @if $global-flexbox {
+    // scss-lint:disable ZeroUnit
     .title-bar-left,
     .title-bar-right {
       flex: 1 1 0px;

diff --git a/scss/components/_top-bar.scss b/scss/components/_top-bar.scss
index f1615b7b8913e846dc0e55df38c36fbee161af8c..239ed970691e20dcaa141e1982ed1b4ea0c5b160 100644 (file)
--- a/scss/components/_top-bar.scss
+++ b/scss/components/_top-bar.scss
@@ -100,6 +100,7 @@ $topbar-unstack-breakpoint: medium !default;
   @if $global-flexbox {
     flex-wrap: nowrap;
 
+    // scss-lint:disable ZeroUnit
     .top-bar-left,
     .top-bar-right {
       flex: 1 1 0px;

diff --git a/scss/forms/_input-group.scss b/scss/forms/_input-group.scss
index da61d64052d2f599bde4eae34c80fb2d7ff03688..c8584593e92897e2fdf45dcc959cfd493450c0e6 100644 (file)
--- a/scss/forms/_input-group.scss
+++ b/scss/forms/_input-group.scss
@@ -87,6 +87,7 @@ $input-prefix-padding: 1rem !default;
     @extend %input-group-child;
     border-radius: 0;
 
+    // scss-lint:disable ZeroUnit
     @if $global-flexbox {
       flex: 1 1 0px;
       width: auto;

diff --git a/scss/forms/_meter.scss b/scss/forms/_meter.scss
index 74e50dbb0820577d1b0cf63c6d9cbe56d4f5fb32..e3740f210f4bacfc1715c95a22e7e50cf8df9bd9 100644 (file)
--- a/scss/forms/_meter.scss
+++ b/scss/forms/_meter.scss
@@ -76,7 +76,7 @@ $meter-fill-bad: $alert-color !default;
       @if has-value($meter-radius) {
         border-radius: $meter-radius;
       }
-    }d
+    }
 
     &::-webkit-meter-even-less-good-value {
       background: $meter-fill-bad;
@@ -86,9 +86,6 @@ $meter-fill-bad: $alert-color !default;
       }
     }
 
-    // Firefox
-    background: $meter-background;
-
     &::-moz-meter-bar {
       background: $primary-color;
 

diff --git a/scss/forms/_range.scss b/scss/forms/_range.scss
index 49f7e7a8c9b0e899ba943d7c30a536b0f8cfa568..f88b5ed341576219ed284bc511c815b65ce9a3be 100644 (file)
--- a/scss/forms/_range.scss
+++ b/scss/forms/_range.scss
@@ -39,10 +39,11 @@ $slider-opacity-disabled: 0.25 !default;
 $slider-radius: $global-radius !default;
 
 @mixin foundation-range-input {
+  // scss-lint:disable QualifyingElement
   input[type="range"] {
     $slider-background: $light-gray;
     $slider-height: 0.5rem;
-    $slider-radius: 0px;
+    $slider-radius: 0;
     $slider-thumb-height: 1.4rem;
     $slider-thumb-width: 1.4rem;
     $slider-thumb-color: $primary-color;
@@ -61,7 +62,6 @@ $slider-radius: $global-radius !default;
     margin-bottom: $margin;
     border: 0;
     line-height: 1;
-    margin-bottom: $global-margin;
 
     @if has-value($slider-radius) {
       border-radius: $slider-radius;
@@ -97,9 +97,9 @@ $slider-radius: $global-radius !default;
     &::-moz-range-track {
       -moz-appearance: none;
       height: $slider-height;
-      background: #ccc;
+      background: $slider-background;
     }
-    
+
     &::-moz-range-thumb {
       -moz-appearance: none;
       background: $slider-thumb-color;

diff --git a/scss/grid/_grid.scss b/scss/grid/_grid.scss
index 561060a63537b05692e3707e3c1d39de370dd39f..646cdaab602e642f9efeba015b6e95ae98686b9a 100644 (file)
--- a/scss/grid/_grid.scss
+++ b/scss/grid/_grid.scss
@@ -37,6 +37,7 @@ $-zf-end-float: if($grid-column-align-edge, $global-right, $global-left);
 // Remove this in 6.3
 $grid-column-responsive-gutter: null !default;
 @if $grid-column-responsive-gutter {
+  // scss-lint:disable DebugStatement
   @debug 'Rename $grid-column-responsive-gutter to $grid-column-gutter to remove this warning.';
   $grid-column-gutter: $grid-column-responsive-gutter;
 }