]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/tests: hdmi: handle empty modes in find_preferred_mode()
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sat, 30 Nov 2024 01:52:26 +0000 (03:52 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thu, 5 Dec 2024 12:36:00 +0000 (14:36 +0200)
If the connector->modes list is empty, then list_first_entry() returns a
bogus entry. Change that to use list_first_entry_or_null().

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241130-hdmi-mode-valid-v5-1-742644ec3b1f@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c

index 294773342e710dc56772f839c2db9c2e487bbc1e..1e77689af6549f162eb3026c7bd2bbd59516ed98 100644 (file)
@@ -46,7 +46,7 @@ static struct drm_display_mode *find_preferred_mode(struct drm_connector *connec
        struct drm_display_mode *mode, *preferred;
 
        mutex_lock(&drm->mode_config.mutex);
-       preferred = list_first_entry(&connector->modes, struct drm_display_mode, head);
+       preferred = list_first_entry_or_null(&connector->modes, struct drm_display_mode, head);
        list_for_each_entry(mode, &connector->modes, head)
                if (mode->type & DRM_MODE_TYPE_PREFERRED)
                        preferred = mode;