]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: cache: Fix leak of cache name in error path
authorTim Duesterhus <tim@bastelstu.be>
Sat, 18 Jan 2020 00:46:18 +0000 (01:46 +0100)
committerWilly Tarreau <w@1wt.eu>
Sat, 18 Jan 2020 05:45:54 +0000 (06:45 +0100)
This issue was introduced in commit 99a17a2d91f9044ea20bba6617048488aed80555
which first appeared in tag v1.9-dev11. This bugfix should be backported
to HAProxy 1.9+.

src/cache.c

index 8e2acd1cb191ef5678efdd776e54df7112d76509..dc11cf532039d5a9ee95ff806fbbcd3ac3e010fc 100644 (file)
@@ -1452,7 +1452,7 @@ parse_cache_flt(char **args, int *cur_arg, struct proxy *px,
                        cconf = NULL;
                        memprintf(err, "%s: multiple explicit declarations of the cache filter '%s'",
                                  px->id, name);
-                       return -1;
+                       goto error;
                }
 
                /* Remove the implicit filter. <cconf> is kept for the explicit one */