]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
Fix mssfix default value in connection_list context
authorLev Stipakov <lstipakov@gmail.com>
Thu, 5 Mar 2015 20:33:56 +0000 (22:33 +0200)
committerGert Doering <gert@greenie.muc.de>
Sat, 7 Mar 2015 11:20:01 +0000 (12:20 +0100)
Due to this bug, mssfix hasn't been assigned to fragment value
and used default value (1450) instead. As a consequence, TCP packets
get fragmented, which causes performance penalty.

Since dual stack patch (commit 23d61c56b9fd218c39ad151b01b7e2d6690e6093)
OpenVPN uses options->connection_list, even for single remote.

This fix assigns mssfix value to fragment value for connection_entry
inside connection_list instead of connection_entry inside options struct
(which does not work for connection_list case).

Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1425587636-23338-1-git-send-email-lstipakov@gmail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/9507

Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/options.c

index 4ea03d1bee4d8fd14809a78bb8cf5cfd3cf19f2e..20b37db9dd17488dfb5fd9c07c5e73846ae99010 100644 (file)
@@ -2352,7 +2352,7 @@ options_postprocess_mutate_ce (struct options *o, struct connection_entry *ce)
     {
 #ifdef ENABLE_FRAGMENT
       if (ce->fragment)
-       o->ce.mssfix = ce->fragment;
+       ce->mssfix = ce->fragment;
 #else
       msg (M_USAGE, "--mssfix must specify a parameter");
 #endif