]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
migrate: detect xml incompatibility
authorEric Blake <eblake@redhat.com>
Thu, 2 Jun 2011 23:40:39 +0000 (17:40 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 3 Jun 2011 14:23:28 +0000 (08:23 -0600)
Detected by Coverity.  Bug introduced in 08106e2044 (unreleased).

* src/conf/domain_conf.c (virDomainChannelDefCheckABIStability):
Use correct sizeof operand.

src/conf/domain_conf.c

index 9975bcae8970e71256a023312e159f3e6a83f3ca..0d9fef4a1dc3add603ab9d183928b78d090933d9 100644 (file)
@@ -7269,7 +7269,8 @@ static bool virDomainChannelDefCheckABIStability(virDomainChrDefPtr src,
         }
         break;
     case VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD:
-        if (memcmp(src->target.addr, dst->target.addr, sizeof(src->target.addr)) != 0) {
+        if (memcmp(src->target.addr, dst->target.addr,
+                   sizeof(*src->target.addr)) != 0) {
             char *saddr = virSocketFormatAddrFull(src->target.addr, true, ":");
             char *daddr = virSocketFormatAddrFull(dst->target.addr, true, ":");
             virDomainReportError(VIR_ERR_CONFIG_UNSUPPORTED,