]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RDMA/rxe: Remove unused page_offset member
authorLi Zhijian <lizhijian@fujitsu.com>
Fri, 16 Jan 2026 03:28:33 +0000 (11:28 +0800)
committerLeon Romanovsky <leon@kernel.org>
Sun, 18 Jan 2026 16:46:15 +0000 (11:46 -0500)
In rxe_map_mr_sg(), the `page_offset` member of the `rxe_mr` struct
was initialized based on `ibmr.iova`, which will be updated inside
ib_sg_to_pages() later.

Consequently, the value assigned to `page_offset` was incorrect. However,
since `page_offset` was never utilized throughout the code, it can be safely
removed to clean up the codebase and avoid future confusion.

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Link: https://patch.msgid.link/20260116032833.2574627-1-lizhijian@fujitsu.com
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/sw/rxe/rxe_mr.c
drivers/infiniband/sw/rxe/rxe_odp.c
drivers/infiniband/sw/rxe/rxe_verbs.h

index b1df05238848810f59c7fc186dc18dc816ac5e77..05710d785a7e767f5f7261a51d5c52f533551ffb 100644 (file)
@@ -237,7 +237,6 @@ int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sgl,
        mr->nbuf = 0;
        mr->page_shift = ilog2(page_size);
        mr->page_mask = ~((u64)page_size - 1);
-       mr->page_offset = mr->ibmr.iova & (page_size - 1);
 
        return ib_sg_to_pages(ibmr, sgl, sg_nents, sg_offset, rxe_set_page);
 }
index ae71812bea82c7084fa21a89aa0dee641c2a1f4f..64295f77563fad4d2e2ab6ada2747be0ca2bfa67 100644 (file)
@@ -110,7 +110,6 @@ int rxe_odp_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length,
        mr->access = access_flags;
        mr->ibmr.length = length;
        mr->ibmr.iova = iova;
-       mr->page_offset = ib_umem_offset(&umem_odp->umem);
 
        err = rxe_odp_init_pages(mr);
        if (err) {
index fd48075810dd1074d8e6915d156d70b724321568..f94ce85eb807c6c234537e25c64a9ec3c8cd3b43 100644 (file)
@@ -347,7 +347,6 @@ struct rxe_mr {
        int                     access;
        atomic_t                num_mw;
 
-       unsigned int            page_offset;
        unsigned int            page_shift;
        u64                     page_mask;