]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
test_voicemail_api: fix warning found by gcc-4.8
authorDavid M. Lee <dlee@digium.com>
Thu, 11 Jul 2013 04:34:49 +0000 (04:34 +0000)
committerDavid M. Lee <dlee@digium.com>
Thu, 11 Jul 2013 04:34:49 +0000 (04:34 +0000)
The voicemail_api test had code like strncmp(a, b, sizeof(a)), but a was a
char pointer, instead of a literal or char array. This meant that sizeof was
the size of the pointer, not the length of the string.

Since the string is in a stringfield and should be null terminated, I just
changed it to a plain strcmp.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@394050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

tests/test_voicemail_api.c

index f80c5b9c95d0ce0e439dd5d63af28e2562a359a1..30f6f11e03af449303eefb35109ad5ef12c69ce0 100644 (file)
@@ -87,7 +87,7 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$")
  * object is test_mbox_snapshot
  */
 #define VM_API_STRING_FIELD_VERIFY(expected, actual) do { \
-       if (strncmp((expected), (actual), sizeof((expected)))) { \
+       if (strcmp((expected), (actual))) { \
                ast_test_status_update(test, "Test failed for parameter %s: Expected [%s], Actual [%s]\n", #actual, expected, actual); \
                VM_API_SNAPSHOT_TEST_CLEANUP; \
                return AST_TEST_FAIL; \