Allow individual chart controllers to opt-in to the decimation plugin (#10182)

* Allow individual chart controllers to opt-in to the decimation plugin

* Code review feedback

diff --git a/src/controllers/controller.line.js b/src/controllers/controller.line.js
index a62d9be895a1e598bce7e1aa18e9595378045df3..be96e72ed793fb94c9bb27fab106e2f420e47327 100644 (file)
--- a/src/controllers/controller.line.js
+++ b/src/controllers/controller.line.js
@@ -7,6 +7,7 @@ export default class LineController extends DatasetController {
 
   initialize() {
     this.enableOptionSharing = true;
+    this.supportsDecimation = true;
     super.initialize();
   }
 

diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js
index b6c6778d999017f73acf03ceddb6ef8b3123f301..85cc50e91627110085e5a8523e0dc9729a92de43 100644 (file)
--- a/src/core/core.datasetController.js
+++ b/src/core/core.datasetController.js
@@ -237,6 +237,7 @@ export default class DatasetController {
     this._drawStart = undefined;
     this._drawCount = undefined;
     this.enableOptionSharing = false;
+    this.supportsDecimation = false;
     this.$context = undefined;
     this._syncList = [];
 

diff --git a/src/plugins/plugin.decimation.js b/src/plugins/plugin.decimation.js
index 20fbb44b93ad574714a594b1e56db9e4ed29e7a1..95604e42966b4a863d9fa0199b20225167fc79f3 100644 (file)
--- a/src/plugins/plugin.decimation.js
+++ b/src/plugins/plugin.decimation.js
@@ -217,7 +217,7 @@ export default {
         return;
       }
 
-      if (meta.type !== 'line') {
+      if (!meta.controller.supportsDecimation) {
         // Only line datasets are supported
         return;
       }

diff --git a/types/index.esm.d.ts b/types/index.esm.d.ts
index ace3a249f7ca5bcf6082f001f7f83f5452ba0baf..882a8df47da198f85ba9542770421fbba0cff21f 100644 (file)
--- a/types/index.esm.d.ts
+++ b/types/index.esm.d.ts
@@ -578,6 +578,10 @@ export class DatasetController<
   readonly index: number;
   readonly _cachedMeta: ChartMeta<TElement, TDatasetElement, TType>;
   enableOptionSharing: boolean;
+  // If true, the controller supports the decimation
+  // plugin. Defaults to `false` for all controllers
+  // except the LineController
+  supportsDecimation: boolean;
 
   linkScales(): void;
   getAllParsedValues(scale: Scale): number[];