Bug 292768: [PostgreSQL] COALESCE requires both arguments to be of similar types

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=glob, r=dkl, a=justdave

diff --git a/CGI.pl b/CGI.pl
index d2a6b50efa04b9cfe3bb9665abbbbaa4829879a9..e00881ade29276cae1ae8007a494f5da330ea820 100644 (file)
--- a/CGI.pl
+++ b/CGI.pl
@@ -262,8 +262,13 @@ sub GetBugActivity {
         $suppwhere = "AND COALESCE(attachments.isprivate, 0) = 0";
     }
     my $query = "
-        SELECT COALESCE(fielddefs.description, bugs_activity.fieldid),
-               fielddefs.name, bugs_activity.attach_id, " .
+        SELECT COALESCE(fielddefs.description, " 
+               # This is a hack - PostgreSQL requires both COALESCE
+               # arguments to be of the same type, and this is the only
+               # way supported by both MySQL 3 and PostgreSQL to convert
+               # an integer to a string. MySQL 4 supports CAST.
+               . $dbh->sql_string_concat('bugs_activity.fieldid', q{''}) .
+               "), fielddefs.name, bugs_activity.attach_id, " .
         $dbh->sql_date_format('bugs_activity.bug_when', '%Y.%m.%d %H:%i:%s') .
             ", bugs_activity.removed, bugs_activity.added, profiles.login_name
           FROM bugs_activity