]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
extcon: max8997: select IRQ_DOMAIN instead of depending on it
authorRandy Dunlap <rdunlap@infradead.org>
Tue, 13 Feb 2024 06:00:28 +0000 (22:00 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:39 +0000 (13:39 +0200)
[ Upstream commit b1781d0a1458070d40134e4f3412ec9d70099bec ]

IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
it directly thru "make *config", so drivers should select it instead
of depending on it if they need it.
Relying on it being set for a dependency is risky.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change EXTCON_MAX8997's use of "depends on" for
IRQ_DOMAIN to "select".

Link: https://lore.kernel.org/lkml/20240213060028.9744-1-rdunlap@infradead.org/
Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/extcon/Kconfig

index 7684b3afa630435c17b64683381ee8d04c4c9262..ba0542ef4d888f8d2afc405a469f5dd271babeba 100644 (file)
@@ -113,7 +113,8 @@ config EXTCON_MAX77843
 
 config EXTCON_MAX8997
        tristate "Maxim MAX8997 EXTCON Support"
-       depends on MFD_MAX8997 && IRQ_DOMAIN
+       depends on MFD_MAX8997
+       select IRQ_DOMAIN
        help
          If you say yes here you get support for the MUIC device of
          Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory