]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
backport: re PR libstdc++/68863 (Regular expressions: Backreferences don't work in...
authorTim Shen <timshen@google.com>
Tue, 15 Dec 2015 05:59:01 +0000 (05:59 +0000)
committerTim Shen <timshen@gcc.gnu.org>
Tue, 15 Dec 2015 05:59:01 +0000 (05:59 +0000)
Backport from mainline
2015-12-15  Tim Shen  <timshen@google.com>

PR libstdc++/68863
* include/bits/regex_executor.tcc (_Executor::_M_lookahead):
Copy the captured content for lookahead, so that the backreferences
inside can refer to them.
* testsuite/28_regex/algorithms/regex_match/ecma/char/68863.cc:
New testcase.

From-SVN: r231643

libstdc++-v3/ChangeLog
libstdc++-v3/include/bits/regex_executor.tcc
libstdc++-v3/testsuite/28_regex/algorithms/regex_match/ecma/char/68863.cc [new file with mode: 0644]

index 70774cce9aba502cddaaa748554a228d2170c76d..ddae62f66b2d6df8cd60937f5f70e8495180c300 100644 (file)
@@ -1,3 +1,15 @@
+2015-12-15  Tim Shen  <timshen@google.com>
+
+       Backport from mainline
+       2015-12-15  Tim Shen  <timshen@google.com>
+
+       PR libstdc++/68863
+       * include/bits/regex_executor.tcc (_Executor::_M_lookahead):
+       Copy the captured content for lookahead, so that the backreferences
+       inside can refer to them.
+       * testsuite/28_regex/algorithms/regex_match/ecma/char/68863.cc:
+       New testcase.
+
 2015-10-02  Jonathan Wakely  <jwakely@redhat.com>
 
        PR libstdc++/65142
index 1dc65435f116248b50c6149523779063ea48a9c3..3ef1789febf2d3f1ecaac26bfb47216c2a12d9e6 100644 (file)
@@ -144,7 +144,10 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
     bool _Executor<_BiIter, _Alloc, _TraitsT, __dfs_mode>::
     _M_lookahead(_State<_TraitsT> __state)
     {
-      _ResultsVec __what(_M_cur_results.size());
+      // Backreferences may refer to captured content.
+      // We may want to make this faster by not copying,
+      // but let's not be clever prematurely.
+      _ResultsVec __what(_M_cur_results);
       auto __sub = std::unique_ptr<_Executor>(new _Executor(_M_current,
                                                            _M_end,
                                                            __what,
diff --git a/libstdc++-v3/testsuite/28_regex/algorithms/regex_match/ecma/char/68863.cc b/libstdc++-v3/testsuite/28_regex/algorithms/regex_match/ecma/char/68863.cc
new file mode 100644 (file)
index 0000000..9e7a9a7
--- /dev/null
@@ -0,0 +1,43 @@
+// { dg-options "-std=gnu++11" }
+
+// Copyright (C) 2015 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// 28.11.2 regex_match
+
+#include <regex>
+#include <testsuite_hooks.h>
+#include <testsuite_regex.h>
+
+using namespace __gnu_test;
+using namespace std;
+
+// libstdc++/68863
+void
+test01()
+{
+  bool test __attribute__((unused)) = true;
+
+  VERIFY(!std::regex_match("aa", std::regex("(.)(?!\\1).")));
+}
+
+int
+main()
+{
+  test01();
+  return 0;
+}