tests: Set the QEMU driver as privileged in common code

Most test programs were already doing this, and moving it to
the common code ensures we see consistent behavior across all
QEMU tests.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

diff --git a/tests/qemumemlocktest.c b/tests/qemumemlocktest.c
index a03ed20a456d29cba1b55fbe46797bca91b66aca..2f4fe786f5a119f6009fe680ab4ca0a69fb4b5dd 100644 (file)
--- a/tests/qemumemlocktest.c
+++ b/tests/qemumemlocktest.c
@@ -51,8 +51,6 @@ mymain(void)
     if (qemuTestDriverInit(&driver) < 0)
         return EXIT_FAILURE;
 
-    driver.privileged = true;
-
 # define DO_TEST(name, memlock) \
     do { \
         static struct testInfo info = { \

diff --git a/tests/qemumigrationcookiexmltest.c b/tests/qemumigrationcookiexmltest.c
index 0e5f956a2a7f2da8d9a4edcac10fc099f7a67a68..2f0d84148b30152ea32286da0418aa88cff08dc3 100644 (file)
--- a/tests/qemumigrationcookiexmltest.c
+++ b/tests/qemumigrationcookiexmltest.c
@@ -413,8 +413,6 @@ mymain(void)
     if (qemuTestDriverInit(&driver) < 0)
         return EXIT_FAILURE;
 
-    driver.privileged = true;
-
     if (!(conn = virGetConnect()))
         goto cleanup;
 

diff --git a/tests/qemustatusxml2xmltest.c b/tests/qemustatusxml2xmltest.c
index 7587c4c34ff632868b1a88f459b8cc937b44f78f..408955a8f570d8e4a8d136374ce48bca460ca6ea 100644 (file)
--- a/tests/qemustatusxml2xmltest.c
+++ b/tests/qemustatusxml2xmltest.c
@@ -87,8 +87,6 @@ mymain(void)
     if (qemuTestDriverInit(&driver) < 0)
         return EXIT_FAILURE;
 
-    driver.privileged = true;
-
     if (!(conn = virGetConnect()))
         goto cleanup;
 

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index c41c890fc96fc9bf5d2477bc656cea580e9a67a4..289fcf8014896076b5b4b65f83f868dab7aca283 100644 (file)
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -830,8 +830,6 @@ mymain(void)
     linuxCaps = driver.caps;
     macOSCaps = testQemuCapsInitMacOS();
 
-    driver.privileged = true;
-
     VIR_FREE(driver.config->defaultTLSx509certdir);
     driver.config->defaultTLSx509certdir = g_strdup("/etc/pki/qemu");
     VIR_FREE(driver.config->vncTLSx509certdir);

diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index ef6c829afe0de0822756154ed9ac56c434d789e4..847ebe85c688b86d0e9094a04100394e18b2e102 100644 (file)
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -148,7 +148,6 @@ mymain(void)
     macOSCaps = testQemuCapsInitMacOS();
 
     cfg = virQEMUDriverGetConfig(&driver);
-    driver.privileged = true;
 
     VIR_FREE(cfg->nvramDir);
     cfg->nvramDir = g_strdup("/var/lib/libvirt/qemu/nvram");

diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index e47e93e8a66197d7b2ce1446b83005d68cfefe75..9983130399a7f547305eb26ab66bed6be07b41d1 100644 (file)
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -683,6 +683,8 @@ int qemuTestDriverInit(virQEMUDriver *driver)
 
     qemuTestSetHostCPU(driver, driver->hostarch, NULL);
 
+    driver->privileged = true;
+
     return 0;
 
  error: