f2fs: compress: fix to check unreleased compressed cluster

[ Upstream commit eb8fbaa53374e0a2d4381190abfe708481517bbb ]

Compressed cluster may not be released due to we can fail in
release_compress_blocks(), fix to handle reserved compressed
cluster correctly in reserve_compress_blocks().

Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Sheng Yong <shengyong@oppo.com>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index dcf2d926ab59d4d7c1dd4c2976d3d84429d11355..436a59d33c923a06eb297b86f9280fb1835b9342 100644 (file)
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3631,7 +3631,13 @@ static int reserve_compress_blocks(struct dnode_of_data *dn, pgoff_t count)
                                goto next;
                        }
 
-                       if (__is_valid_data_blkaddr(blkaddr)) {
+                       /*
+                        * compressed cluster was not released due to it
+                        * fails in release_compress_blocks(), so NEW_ADDR
+                        * is a possible case.
+                        */
+                       if (blkaddr == NEW_ADDR ||
+                               __is_valid_data_blkaddr(blkaddr)) {
                                compr_blocks++;
                                continue;
                        }
@@ -3641,6 +3647,11 @@ static int reserve_compress_blocks(struct dnode_of_data *dn, pgoff_t count)
                }
 
                reserved = cluster_size - compr_blocks;
+
+               /* for the case all blocks in cluster were reserved */
+               if (reserved == 1)
+                       goto next;
+
                ret = inc_valid_block_count(sbi, dn->inode, &reserved);
                if (ret)
                        return ret;